fix(legacy): use symbol name instead of EVM network shortcut
What the developer wrote
Authored by Roman Zeyde
fix(legacy): use symbol name instead of EVM network shortcut
What changed, and why it matters
This commit fixes a data-generation template for Trezor's older (legacy) firmware so that Ethereum network entries use the proper currency symbol and network name fields instead of incorrectly copying the network shortcut into the symbol field and leaving the name blank. It appears to be a UI/labeling correctness fix rather than a vulnerability, but the change could affect what users see when confirming Ethereum transactions on the device.
Treat as a routine correctness/UI fix. Review the generated `ethereum_networks.c` output to confirm symbols and names render correctly on the legacy device screen, and verify that downstream transaction signing prompts display the intended network identity to users.
Security signals we found
UI display field correction for cryptocurrency transaction confirmation
Generated data structure field mapping fix
No explicit security claim in commit message or changelog fragment
Evidence from the diff
The change is in legacy/firmware/ethereum_networks.c.mako, a Mako template that generates a C array of EthereumNetworkInfo structures. Previously, the .symbol field was populated with n.shortcut (e.g., an EVM network shortcut like ‘ETH’ or a ticker-like label) and .name was hardcoded to an empty string. The patch populates .symbol with n.symbol and .name with n.name. This aligns the generated C code with the intended data model and likely fixes incorrect or missing on-device display strings for EVM networks. There is no direct evidence in the diff of memory corruption, buffer mishandling, or cryptographic weakness.
Changed components
legacy/firmware/ethereum_networks.c.makolegacy Ethereum network metadata generationInspect captured patch +3 / −2
diff --git a/legacy/firmware/.changelog.d/5194.fixed b/legacy/firmware/.changelog.d/5194.fixed
new file mode 100644
index 00000000..a25af5fa
--- /dev/null
+++ b/legacy/firmware/.changelog.d/5194.fixed
@@ -0,0 +1 @@
+Use network symbol instead of EVM network shortcut.
diff --git a/legacy/firmware/ethereum_networks.c.mako b/legacy/firmware/ethereum_networks.c.mako
index a3b863e0..ad605c05 100644
--- a/legacy/firmware/ethereum_networks.c.mako
+++ b/legacy/firmware/ethereum_networks.c.mako
@@ -12,8 +12,8 @@ static const EthereumNetworkInfo networks[NETWORKS_COUNT] = {
{
.chain_id = ${n.chain_id},
.slip44 = ${n.slip44},
- .symbol = ${c_str(n.shortcut)}, /* ${n.name} */
- .name = "",
+ .symbol = ${c_str(n.symbol)},
+ .name = ${c_str(n.name)},
},
% endfor
};
Why this scored 16/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.