What the developer wrote
Authored by Ioan Bizău
chore: remove sleep
[no changelog]
What changed, and why it matters
This commit removes a 2-second delay in internal test code that waits for a Trezor emulator component to be ready. It is a test/development tooling change with no apparent security relevance.
No security action required. Treat as a normal test-harness cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes a time.sleep(2) call inside python/src/trezorlib/_internal/emulator.py, in a loop that waits for a local Tropic model emulator process to accept connections on 127.0.0.1. The removed comment noted that even when the model was listening, it sometimes needed extra time before processing requests correctly. This is purely internal test infrastructure code and does not change firmware behavior, cryptographic operations, or device-facing logic.
Changed components
python/src/trezorlib/_internal/emulator.pyInspect captured patch +0 / −4
diff --git a/python/src/trezorlib/_internal/emulator.py b/python/src/trezorlib/_internal/emulator.py
index 9ee093e48..fc812639e 100644
--- a/python/src/trezorlib/_internal/emulator.py
+++ b/python/src/trezorlib/_internal/emulator.py
@@ -127,10 +127,6 @@ class TropicModel:
# where we told the model to listen
result = s.connect_ex(("127.0.0.1", self.port))
if result == 0:
- # seems that even if the model is listening for connections
- # it sometimes needs up to 2 seconds more
- # before it actually correctly processes requests
- time.sleep(2)
break
if self.process.poll() is not None:
raise RuntimeError("Tropic model process died")
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.