fix(core/ui): stop dropping the subtitle of the Stellar amount screen on caesar.
What the developer wrote
Authored by Jun Luo
fix(core/ui): stop dropping the subtitle of the Stellar amount screen on caesar.
[no changelog]
What changed, and why it matters
This commit fixes a user-interface bug in Trezor hardware wallets where the subtitle line on the Stellar cryptocurrency transaction confirmation screen was accidentally dropped. The fix joins the title and subtitle into a single line so users see both pieces of context before signing. It is a UI clarity issue, not a cryptographic or code-execution vulnerability.
No urgent security action required. Include the fix in the next regular firmware release and verify that Stellar amount confirmation screens display both title and subtitle as expected.
Security signals we found
UI information-loss bug that could reduce clarity of transaction confirmation
No cryptographic, memory-safety, or authorization weakness present in diff
Fix is localized to a single layout helper and a single call site
Evidence from the diff
In core/src/trezor/ui/layouts/caesar/init.py, confirm_stellar_output_amount previously passed only title to confirm_value, ignoring the subtitle parameter. The Caesar layout has no dedicated subtitle slot, so subtitle was silently omitted. The patch adds a local helper _stellar_title that concatenates title and subtitle, and passes the combined string to confirm_value. This restores intended on-screen context for Stellar output amount confirmations.
Changed components
core/src/trezor/ui/layouts/caesar/__init__.pyStellar transaction confirmation UI on Caesar-layout Trezor devicesInspect captured patch +5 / −1
### core/src/trezor/ui/layouts/caesar/__init__.py
@@ -1841,6 +1841,10 @@ async def confirm_stellar_tx(
br_code=ButtonRequestType.SignTx,
)
+ def _stellar_title(title: str, subtitle: str) -> str:
+ # the layouts used here have no subtitle slot, join both parts into the title
+ return f"{title}: {subtitle}" if subtitle else title
+
async def confirm_stellar_output_amount(
title: str,
subtitle: str,
@@ -1861,7 +1865,7 @@ async def confirm_stellar_output_amount(
]
await confirm_value(
- title,
+ _stellar_title(title, subtitle),
amount,
description,
br_name="confirm_output_amount",Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.