ci(core): avoid running `core_ui_comment` job for other repositories
What changed, and why it matters
This is a minor GitHub Actions CI workflow tweak. It adds an extra condition so a job that posts UI comparison comments only runs in the official Trezor firmware repository, preventing harmless failures when the workflow runs in forks or other repositories. There is no product security issue.
No security action needed. Treat as a normal CI maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies .github/workflows/core.yml for the core_ui_comment job. The existing condition skipped the job for external pull requests; the new condition additionally requires github.repository == 'trezor/trezor-firmware'. This stops the job from executing in forks or copied repositories, where the aws-actions/configure-aws-credentials step would fail due to missing secrets or permissions. It is a CI reliability/configuration hardening change, not a vulnerability fix.
Changed components
.github/workflows/core.ymlcore_ui_comment GitHub Actions jobInspect captured patch +2 / −2
diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml
index 1b2fca40..7f0cf152 100644
--- a/.github/workflows/core.yml
+++ b/.github/workflows/core.yml
@@ -690,8 +690,8 @@ jobs:
core_ui_comment:
name: Post comment with UI diff URLs
- # skip UI comment job on external PRs (see #5381)
- if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
+ # run UI comment job only for 'trezor/trezor-firmware' scheduled workflows and internal PRs (see #5381)
+ if: (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && github.repository == 'trezor/trezor-firmware'
runs-on: ubuntu-latest
needs:
- param
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.