What the developer wrote
Authored by Martin Milata
build(core): fix Makefile indentation
[no changelog]
What changed, and why it matters
This commit only fixes whitespace indentation in a Makefile. It moves a few conditional build-option lines from being indented with a tab to being flush-left, which is required for GNU Make to recognize them as part of the else branch rather than as recipe commands. There is no functional code change and no security relevance.
No security action needed. Treat as a normal build-system hygiene fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff in core/Makefile corrects the indentation of nested ifeq/endif blocks inside an else branch. In GNU Make, conditional directives must not be indented with tabs because a tab at the start of a line marks a recipe line. The previous indentation likely caused Make to misparse the conditionals or issue warnings/errors. The commit aligns the directives at column 0 so they are evaluated as make conditionals, but the resulting logic (adding –disable-optiga or –disable-tropic when the corresponding DISABLE_* variable is set) remains unchanged.
Changed components
core/MakefileInspect captured patch +6 / −6
diff --git a/core/Makefile b/core/Makefile
index 67173809..02e14ea7 100644
--- a/core/Makefile
+++ b/core/Makefile
@@ -65,12 +65,12 @@ XTASK_BUILD_OPTS += --storage-insecure-testing-mode
XTASK_BUILD_OPTS += --disable-tropic
XTASK_BUILD_OPTS += --disable-optiga
else
- ifeq ($(DISABLE_OPTIGA),1)
- XTASK_BUILD_OPTS += --disable-optiga
- endif
- ifeq ($(DISABLE_TROPIC),1)
- XTASK_BUILD_OPTS += --disable-tropic
- endif
+ifeq ($(DISABLE_OPTIGA),1)
+XTASK_BUILD_OPTS += --disable-optiga
+endif
+ifeq ($(DISABLE_TROPIC),1)
+XTASK_BUILD_OPTS += --disable-tropic
+endif
endif
## help commands:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.