chore(core): remove unneeded `sleep()` from `test_repeated_backup_via_device`
What the developer wrote
Authored by Roman Zeyde
chore(core): remove unneeded `sleep()` from `test_repeated_backup_via_device`
[no changelog]
What changed, and why it matters
This commit removes a short 0.1-second delay from an automated test script. It does not change the actual Trezor firmware or any code that runs on user devices. There is no security issue here.
No action needed. This is a benign test-only cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change deletes an import time and a time.sleep(0.1) workaround in tests/click_tests/test_repeated_backup.py. The TODO comment indicates the sleep was a temporary test-flakiness workaround tied to issue #5546 and pull request #5499. This is purely a test-code cleanup with no product-code modifications.
Changed components
tests/click_tests/test_repeated_backup.pyInspect captured patch +0 / −4
diff --git a/tests/click_tests/test_repeated_backup.py b/tests/click_tests/test_repeated_backup.py
index 2c4d8d345..f7a0ef230 100644
--- a/tests/click_tests/test_repeated_backup.py
+++ b/tests/click_tests/test_repeated_backup.py
@@ -14,7 +14,6 @@
# You should have received a copy of the License along with this library.
# If not, see <https://www.gnu.org/licenses/lgpl-3.0.html>.
-import time
from typing import TYPE_CHECKING
import pytest
@@ -209,9 +208,6 @@ def test_repeated_backup_via_device(
assert features.no_backup is False
assert features.recovery_status == messages.RecoveryStatus.Backup
- # TODO: remove after #5546 (added as workaround for https://github.com/trezor/trezor-firmware/pull/5499#issuecomment-3187459469)
- time.sleep(0.1)
-
# but if we cancel the backup at this point...
reset.cancel_backup(debug)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.