CommitWatch RSS
AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 41 Bitcoin

feat(ethereum): add support for erc-4626 withdraw and redeem flow

TZb30022e5 View source ↗
Public commit record

What the developer wrote

Authored by PrisionMike

95/100 · Strong
feat(ethereum): add support for erc-4626 withdraw and redeem flow

- Updates vault with latest test
- Adds concept of safe_tx
- blind sign unsafe transaction with unkown vaults
- clear sign safe transaction everywhere
- refactor

[no changelog]
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
The short version

What changed, and why it matters

This commit expands Trezor's Ethereum 'clear signing' support to include ERC-4626 vault withdraw and redeem transactions, not just deposits. For transactions where the receiver or owner differs from the signer on an unknown vault, the device now falls back to blind signing instead of refusing outright. For known Trezor-listed vaults, mismatches still trigger a hard error. The change is a feature addition with intentional security trade-offs rather than a clear-cut vulnerability patch.

Recommended action

Review the security policy decision to allow blind signing for unknown-vault transactions with receiver/owner mismatches, and ensure the fallback path cannot be abused to hide malicious ERC-4626 calls behind a generic data-signing prompt. Consider whether additional warnings are needed when a previously clear-signable selector is downgraded to blind signing.

Security signals we found

01

New clear-signing path for ERC-4626 withdraw/redeem selectors

02

Intentional fallback to blind signing for 'unsafe' unknown vault transactions

03

Hard failure retained for mismatched receiver/owner on known vaults

04

Validation added for native ETH value, trailing calldata bytes, and zero amounts

05

Test fixtures explicitly cover mismatch cases and label them as falling through to blind signing

Risk score

Why this scored 41/100

Our methodology →
Potential impact 8/30
Exploitability 7/25
Stealth signal 6/15
Affected reach 9/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

More from Trezor firmware

Related watches

Informational 18 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core): remove sha1 from regular FW

This commit removes the SHA-1 hashing function from the regular Trezor firmware. SHA-1 is an old, weak hash algorithm that is no longer considered secure for sensitive uses. The change deletes the code that exposes SHA-1 to apps running on…

Removal of a deprecated cryptographic primitive (SHA-1) from the firmware API surfaceReduction of attack surface and prevention of future misuse of a collision-vulnerable hashNo direct vulnerability patch or memory-safety bug is present in the diff
16d15774by M1nd3r+0−2006 files
No security note in commit
Open full analysis →Source commit ↗
Low 27 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): pass static public key to `noise_xxpsk3_*_init()`

This commit changes how a cryptographic library sets up secure connections. Previously, the code automatically calculated the public key from the private key. Now, the caller must provide the public key directly. This is a code-quality ref…

Cryptographic key handling changed: public key is now supplied rather than derivedPotential reduction of key-mismatch risk if caller provides correct public keyNew null-pointer check added for static_public_key
1b3128a4by Ondřej Vejpustek+20−92 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): change order of parameters

This commit simply reorders the arguments of an internal function called dh() and updates every place that calls it. The actual math and security behavior are unchanged; it is a code cleanup with no security effect.

33a119eeby Ondřej Vejpustek+15−151 file
No security note in commit
Open full analysis →Source commit ↗