build(core): remove `#error` from core/embed/upymod/qstrdefsport.h
What the developer wrote
Authored by Roman Zeyde
build(core): remove `#error` from core/embed/upymod/qstrdefsport.h
Otherwise, every build emits the following unhelpful message during `PreprocessQstr` step:
```
<stdin>:5279:2: error: #error This header should not be part of the build, its purpose is only to add missed Qstrings
```
[no changelog]
What changed, and why it matters
This commit simply turns a build-time compiler error message into a plain comment. The file is a generated helper used to add missing text labels (Qstrings) to the device's MicroPython frozen string pool. The change removes a noisy but harmless '#error' directive that was being printed during every build. There is no security relevance.
No security action needed. This is a build-hygiene cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit changes ‘#error This header should not be part of the build…’ into a regular ‘//’ comment in both the generated header (qstrdefsport.h) and its Mako template (qstrdefsport.h.mako). The header is not compiled into the firmware; it exists only to inject extra QSTR definitions into MicroPython’s frozen Qstr pool. The ‘#error’ was being emitted during the PreprocessQstr build step, which the developer found unhelpful. No functional code, logic, or security boundary is modified.
Changed components
core/embed/upymod/qstrdefsport.hcore/embed/upymod/qstrdefsport.h.makoInspect captured patch +4 / −2
diff --git a/core/embed/upymod/qstrdefsport.h b/core/embed/upymod/qstrdefsport.h
index 85e6aaa6..6d50a0a8 100644
--- a/core/embed/upymod/qstrdefsport.h
+++ b/core/embed/upymod/qstrdefsport.h
@@ -3,7 +3,8 @@
// do not edit manually!
// fmt: off
-#error This header should not be part of the build, its purpose is only to add missed Qstrings
+// This header should not be part of the build, its purpose is only to add
+// missed Qstrings to MicroPython frozen Qstr pool.
// explanation:
// uPy collects string literals and symbol names from all frozen modules, and
diff --git a/core/embed/upymod/qstrdefsport.h.mako b/core/embed/upymod/qstrdefsport.h.mako
index 19ac8d12..c703f433 100644
--- a/core/embed/upymod/qstrdefsport.h.mako
+++ b/core/embed/upymod/qstrdefsport.h.mako
@@ -60,7 +60,8 @@ def make_import_qstrs(import_names):
return sorted(import_qstrs)
%>\
-#error This header should not be part of the build, its purpose is only to add missed Qstrings
+// This header should not be part of the build, its purpose is only to add
+// missed Qstrings to MicroPython frozen Qstr pool.
// explanation:
// uPy collects string literals and symbol names from all frozen modules, and
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.