chore(tests): visit menu items in info flow
What the developer wrote
Authored by Ioan Bizău
chore(tests): visit menu items in info flow
[no changelog]
What changed, and why it matters
This commit only renames an internal test helper method from `_visit_menu_items` to `visit_menu_items` and adds a few calls to it in automated test scripts. It does not change any production firmware or device behavior. There is no security issue here.
No action required. This is a routine test-maintenance change with no security relevance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff changes a private method on DebugUI to public by removing the leading underscore, then updates existing call sites and adds new invocations in test input flows for Delizia and Eckhart device models. The method is part of the Python debug/test harness used to exercise UI menu traversal during automated tests. No runtime firmware code is modified.
Changed components
python/src/trezorlib/debuglink.pytests/input_flows.pyInspect captured patch +7 / −4
diff --git a/python/src/trezorlib/debuglink.py b/python/src/trezorlib/debuglink.py
index 232f670df..a7cc898da 100644
--- a/python/src/trezorlib/debuglink.py
+++ b/python/src/trezorlib/debuglink.py
@@ -1055,7 +1055,7 @@ class DebugUI:
menu_layout = self.debuglink.read_layout()
assert "ScrolledVerticalMenu" in menu_layout.all_components()
- def _visit_menu_items(self) -> LayoutContent:
+ def visit_menu_items(self) -> LayoutContent:
layout = self.debuglink.read_layout()
if (
not layout.has_menu()
@@ -1117,7 +1117,7 @@ class DebugUI:
self.debuglink.swipe_up()
# Visit info menus (if exist)
- layout = self._visit_menu_items()
+ layout = self.visit_menu_items()
# Confirm current layout
if self.debuglink.model is models.T3T1:
diff --git a/tests/input_flows.py b/tests/input_flows.py
index 1a6de54ed..740ea82c9 100644
--- a/tests/input_flows.py
+++ b/tests/input_flows.py
@@ -471,7 +471,7 @@ class InputFlowSignMessageInfo(InputFlowBase):
def input_flow_delizia(self) -> BRGeneratorType:
yield
# show address/message info
- self.client.ui._visit_menu_items()
+ self.client.ui.visit_menu_items()
# cancel signature
self.debug.click(self.debug.screen_buttons.menu())
self.debug.button_actions.navigate_to_menu_item(0)
@@ -1095,6 +1095,7 @@ def sign_tx_go_to_info_delizia(
) -> Generator[None, messages.ButtonRequest, str]:
yield # confirm output
client.debug.read_layout()
+ client.ui.visit_menu_items()
client.debug.swipe_up()
yield # confirm output
client.debug.read_layout()
@@ -1134,10 +1135,12 @@ def sign_tx_go_to_info_eckhart(
) -> Generator[None, messages.ButtonRequest, str]:
yield # confirm output
client.debug.read_layout()
+ client.ui.visit_menu_items()
client.debug.click(client.debug.screen_buttons.ok())
yield # confirm output
client.debug.read_layout()
+ client.ui.visit_menu_items()
client.debug.click(client.debug.screen_buttons.ok())
if multi_account:
@@ -2969,7 +2972,7 @@ class InputFlowConfirmAllWarnings(InputFlowBase):
self.debug.swipe_up()
# Visit info menus (if exist)
- layout = self.client.ui._visit_menu_items()
+ layout = self.client.ui.visit_menu_items()
text = layout.footer().lower()
# hi priority warning
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.