CommitWatch RSS
AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 39 Bitcoin

fix(legacy): always use Gwei for ETH fee rates

TZa5fb5adb View source ↗
Public commit record

What the developer wrote

Authored by Roman Zeyde

72/100 · Adequate
fix(legacy): always use Gwei for ETH fee rates

Similar to how it's done in core.

[no changelog]
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
The short version

What changed, and why it matters

This commit changes how the older Trezor One (legacy) firmware displays Ethereum transaction fees on the device screen. Previously, small per-gas fee values could be shown in 'Wei' (the smallest Ethereum unit) instead of always using 'Gwei'. The fix makes per-gas fees consistently display in Gwei, matching the newer Trezor Core firmware. This is a user-interface consistency fix that could have minor security relevance because confusing fee units might lead a user to misread or misapprove a transaction fee, but the commit itself does not change any signing logic or cryptographic checks.

Recommended action

Treat as a low-risk UI hardening fix. Review whether the previous Wei/Gwei fallback behavior could have been exploited to make a fee appear smaller or larger than intended, but note the commit does not address any deeper validation issue. Ensure updated UI fixtures reflect intended display behavior and consider documenting the change for users even though the commit omits a changelog entry.

Security signals we found

01

UI unit formatting inconsistency between legacy and core firmware

02

Potential user confusion between Wei and Gwei for Ethereum gas fees

03

No changes to cryptographic or transaction validation logic

04

Test fixture hash updates indicate expected screen output changed

Risk score

Why this scored 39/100

Our methodology →
Potential impact 8/30
Exploitability 7/25
Stealth signal 6/15
Affected reach 9/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

More from Trezor firmware

Related watches

Informational 18 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core): remove sha1 from regular FW

This commit removes the SHA-1 hashing function from the regular Trezor firmware. SHA-1 is an old, weak hash algorithm that is no longer considered secure for sensitive uses. The change deletes the code that exposes SHA-1 to apps running on…

Removal of a deprecated cryptographic primitive (SHA-1) from the firmware API surfaceReduction of attack surface and prevention of future misuse of a collision-vulnerable hashNo direct vulnerability patch or memory-safety bug is present in the diff
16d15774by M1nd3r+0−2006 files
No security note in commit
Open full analysis →Source commit ↗
Low 27 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): pass static public key to `noise_xxpsk3_*_init()`

This commit changes how a cryptographic library sets up secure connections. Previously, the code automatically calculated the public key from the private key. Now, the caller must provide the public key directly. This is a code-quality ref…

Cryptographic key handling changed: public key is now supplied rather than derivedPotential reduction of key-mismatch risk if caller provides correct public keyNew null-pointer check added for static_public_key
1b3128a4by Ondřej Vejpustek+20−92 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): change order of parameters

This commit simply reorders the arguments of an internal function called dh() and updates every place that calls it. The actual math and security behavior are unchanged; it is a code cleanup with no security effect.

33a119eeby Ondřej Vejpustek+15−151 file
No security note in commit
Open full analysis →Source commit ↗