What the developer wrote
Authored by Ioan Bizău
fix(tests): visit menus on all pages
[no changelog]
What changed, and why it matters
This commit only changes test helper code. It moves calls that exercise on-screen menu items so they happen on every page of a paginated screen, not just the last page. There is no change to the actual Trezor firmware or to how real user transactions are handled, so it does not create or fix a security vulnerability in the device itself.
No security action needed. Treat as a normal test-maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies two test-only files: python/src/trezorlib/debuglink.py and tests/input_flows.py. In DebugUI.read_layout() and in InputFlowConfirmAllWarnings, the call to visit_menu_items() is moved inside the pagination loop so menu items are visited on each page before swiping/clicking to the next page. The final visit_menu_items() call remains after pagination. This is a test-coverage fix to ensure all menu pages are exercised during automated UI tests. No firmware runtime code is touched.
Changed components
tests/input_flows.pypython/src/trezorlib/debuglink.pyInspect captured patch +5 / −3
diff --git a/python/src/trezorlib/debuglink.py b/python/src/trezorlib/debuglink.py
index 689d05b7..0781e877 100644
--- a/python/src/trezorlib/debuglink.py
+++ b/python/src/trezorlib/debuglink.py
@@ -1119,12 +1119,12 @@ class DebugUI:
# Paginating (going as further as possible)
for _ in range(pages - 1):
+ self.visit_menu_items()
if self.debuglink.model is models.T3W1:
self.debuglink.click(self.debuglink.screen_buttons.ok())
else:
self.debuglink.swipe_up()
- # Visit info menus (if exist)
layout = self.visit_menu_items()
# Confirm current layout
diff --git a/tests/input_flows.py b/tests/input_flows.py
index b9b57b04..b276e52b 100644
--- a/tests/input_flows.py
+++ b/tests/input_flows.py
@@ -3039,9 +3039,9 @@ class InputFlowConfirmAllWarnings(InputFlowBase):
# Paginating (going as further as possible) and pressing Yes
if br.pages is not None:
for _ in range(br.pages - 1):
+ self.client.ui.visit_menu_items()
self.debug.swipe_up()
- # Visit info menus (if exist)
layout = self.client.ui.visit_menu_items()
text = layout.footer().lower()
@@ -3069,8 +3069,10 @@ class InputFlowConfirmAllWarnings(InputFlowBase):
# Paginating (going as further as possible) and pressing Yes
if br.pages is not None:
for _ in range(br.pages - 1):
+ self.client.ui.visit_menu_items()
self.debug.click(self.debug.screen_buttons.ok())
- layout = self.debug.read_layout()
+
+ layout = self.client.ui.visit_menu_items()
text = layout.action_bar().lower()
# hi priority warning
hi_prio = (
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.