chore(core): support subtitle on Delizia `should_show_more()`
What the developer wrote
Authored by Roman Zeyde
chore(core): support subtitle on Delizia `should_show_more()`
[no changelog]
What changed, and why it matters
This is a small user-interface feature patch that adds support for displaying an optional subtitle in a Trezor hardware wallet screen flow. It does not change security logic, cryptography, memory handling, or user confirmation behavior. There is no indication this commit fixes or introduces a security issue.
No security action required. Review as normal UI code if desired.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit wires an existing subtitle parameter through the Delizia UI layer. In ui_firmware.rs, the previously ignored _subtitle argument is now passed into ConfirmActionStrings::new. In delizia/__init__.py, should_show_more() gains a subtitle keyword argument that is forwarded to trezorui_api.confirm_with_info(). No logic, validation, or authorization code is altered.
Changed components
core/embed/rust/src/ui/layout_delizia/ui_firmware.rscore/src/trezor/ui/layouts/delizia/__init__.pyInspect captured patch +4 / −2
diff --git a/core/embed/rust/src/ui/layout_delizia/ui_firmware.rs b/core/embed/rust/src/ui/layout_delizia/ui_firmware.rs
index 391d12e8..4aad78b3 100644
--- a/core/embed/rust/src/ui/layout_delizia/ui_firmware.rs
+++ b/core/embed/rust/src/ui/layout_delizia/ui_firmware.rs
@@ -463,7 +463,7 @@ impl FirmwareUI for UIDelizia {
fn confirm_with_info(
title: TString<'static>,
- _subtitle: Option<TString<'static>>,
+ subtitle: Option<TString<'static>>,
items: Obj,
verb: TString<'static>,
verb_info: TString<'static>,
@@ -487,7 +487,7 @@ impl FirmwareUI for UIDelizia {
}
}
- let mut strings = ConfirmActionStrings::new(title, None, None, None);
+ let mut strings = ConfirmActionStrings::new(title, subtitle, None, None);
if !verb.is_empty() {
// skip footer if verb is an empty string
strings = strings.with_footer_description(Some(verb));
diff --git a/core/src/trezor/ui/layouts/delizia/__init__.py b/core/src/trezor/ui/layouts/delizia/__init__.py
index 971a4bff..db7245ee 100644
--- a/core/src/trezor/ui/layouts/delizia/__init__.py
+++ b/core/src/trezor/ui/layouts/delizia/__init__.py
@@ -682,6 +682,7 @@ async def should_show_more(
br_name: str = "should_show_more",
br_code: ButtonRequestType = BR_CODE_OTHER,
confirm: str | None = None,
+ subtitle: str | None = None,
) -> bool:
"""Return True if the user wants to show more (they click a special button)
and False when the user wants to continue without showing details.
@@ -693,6 +694,7 @@ async def should_show_more(
result = await interact(
trezorui_api.confirm_with_info(
title=title,
+ subtitle=subtitle,
items=para,
verb=(TR.buttons__confirm if confirm is None else confirm),
verb_info=button_text,
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.