fix(core): correct a typo in recovery-related layout function name

Trezor/Trezor firmware

8ef2caeb View source ↗

Public commit record

What the developer wrote

Authored by Roman Zeyde

62/100 · Adequate

fix(core): correct a typo in recovery-related layout function name

[no changelog]

✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body

The short version

What changed, and why it matters

This commit fixes a spelling mistake in a function name used during wallet recovery on Trezor hardware wallets. The old misspelled name 'show_group_thresholod' is replaced with the correct 'show_group_threshold' across all device layouts. There is no security issue here—just a typo cleanup.

Recommended action

No security action needed. This is a cosmetic code-quality fix.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The change is a pure identifier rename from ‘show_group_thresholod’ to ‘show_group_threshold’ in five files: the recovery_device layout controller and four UI layout implementations (bolt, caesar, delizia, eckhart). The function displays a warning when a recovery group threshold is reached. The rename is consistent across imports, call sites, and definitions, and the behavior is unchanged.

Changed components

core/src/apps/management/recovery_device/layout.pycore/src/trezor/ui/layouts/bolt/recovery.pycore/src/trezor/ui/layouts/caesar/recovery.pycore/src/trezor/ui/layouts/delizia/recovery.pycore/src/trezor/ui/layouts/eckhart/recovery.py

Inspect captured patch +6 / −6

diff --git a/core/src/apps/management/recovery_device/layout.py b/core/src/apps/management/recovery_device/layout.py
index eb8d5540..a03f4281 100644
--- a/core/src/apps/management/recovery_device/layout.py
+++ b/core/src/apps/management/recovery_device/layout.py
@@ -6,7 +6,7 @@ from trezor.ui.layouts.recovery import (  # noqa: F401
     show_already_added,
     show_dry_run_result,
     show_group_share_success,
-    show_group_thresholod,
+    show_group_threshold,
     show_identifier_mismatch,
     show_recovery_warning,
 )
@@ -81,7 +81,7 @@ async def request_mnemonic(
             return None
         except word_validity.ThresholdReached:
             # show_group_threshold_reached
-            await show_group_thresholod()
+            await show_group_threshold()
             return None
 
     return " ".join(words)
diff --git a/core/src/trezor/ui/layouts/bolt/recovery.py b/core/src/trezor/ui/layouts/bolt/recovery.py
index 6bd39be3..9ceda554 100644
--- a/core/src/trezor/ui/layouts/bolt/recovery.py
+++ b/core/src/trezor/ui/layouts/bolt/recovery.py
@@ -222,7 +222,7 @@ async def show_already_added() -> None:
     )
 
 
-async def show_group_thresholod() -> None:
+async def show_group_threshold() -> None:
     await show_recovery_warning(
         "warning_group_threshold",
         TR.recovery__group_threshold_reached,
diff --git a/core/src/trezor/ui/layouts/caesar/recovery.py b/core/src/trezor/ui/layouts/caesar/recovery.py
index b5b1a9d3..0cfa4017 100644
--- a/core/src/trezor/ui/layouts/caesar/recovery.py
+++ b/core/src/trezor/ui/layouts/caesar/recovery.py
@@ -183,7 +183,7 @@ async def show_already_added() -> None:
     )
 
 
-async def show_group_thresholod() -> None:
+async def show_group_threshold() -> None:
     await show_recovery_warning(
         "warning_group_threshold",
         TR.recovery__group_threshold_reached,
diff --git a/core/src/trezor/ui/layouts/delizia/recovery.py b/core/src/trezor/ui/layouts/delizia/recovery.py
index 7bc2836d..89276656 100644
--- a/core/src/trezor/ui/layouts/delizia/recovery.py
+++ b/core/src/trezor/ui/layouts/delizia/recovery.py
@@ -164,7 +164,7 @@ async def show_already_added() -> None:
     )
 
 
-async def show_group_thresholod() -> None:
+async def show_group_threshold() -> None:
     await show_recovery_warning(
         "warning_group_threshold",
         TR.recovery__group_threshold_reached,
diff --git a/core/src/trezor/ui/layouts/eckhart/recovery.py b/core/src/trezor/ui/layouts/eckhart/recovery.py
index 151a7b63..2da4e15d 100644
--- a/core/src/trezor/ui/layouts/eckhart/recovery.py
+++ b/core/src/trezor/ui/layouts/eckhart/recovery.py
@@ -162,7 +162,7 @@ async def show_already_added() -> None:
     )
 
 
-async def show_group_thresholod() -> None:
+async def show_group_threshold() -> None:
     await show_recovery_warning(
         "warning_group_threshold",
         f"{TR.recovery__group_threshold_reached} {TR.recovery__enter_share_from_diff_group}",

Risk score

Why this scored 15/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 0/15

Confidence 10/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 15/100

Community notes

Related watches

chore(core): remove sha1 from regular FW

refactor(crypto): pass static public key to `noise_xxpsk3_*_init()`

refactor(crypto): change order of parameters