What the developer wrote
Authored by Ondřej Vejpustek
fix(crypto): fix empty array warning
[no changelog]
What changed, and why it matters
This commit changes a function parameter declaration from an empty array syntax to a pointer syntax in the Noise protocol cryptography code. It is purely a coding-style/compiler-warning fix with no functional change to the program's behavior or security.
No security action required; this is a benign warning-suppression refactor.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies noise_handle_handshake_response_multiple_keys in both crypto/noise.c and crypto/noise.h, changing const curve25519_key responder_public_keys[] to const curve25519_key *responder_public_keys. In C, a parameter declared as type x[] is adjusted to type *x anyway, so this is semantically equivalent. The commit message states it fixes an ‘empty array warning’ and explicitly marks ‘[no changelog]’, indicating no behavioral or security change.
Changed components
crypto/noise.ccrypto/noise.hInspect captured patch +2 / −2
diff --git a/crypto/noise.c b/crypto/noise.c
index b50dec8f..eff0e714 100644
--- a/crypto/noise.c
+++ b/crypto/noise.c
@@ -338,7 +338,7 @@ bool noise_receive_message(noise_context_t *ctx, const uint8_t *associated_data,
bool noise_handle_handshake_response_multiple_keys(
noise_context_t *ctx, const curve25519_key initiator_private_key,
- const curve25519_key responder_public_keys[],
+ const curve25519_key *responder_public_keys,
size_t responder_public_keys_count, const noise_response_t *response) {
curve25519_key ephemeral_key_backup = {0};
memcpy(ephemeral_key_backup, ctx->initiator_ephemeral_private_key,
diff --git a/crypto/noise.h b/crypto/noise.h
index 86869343..d3d66f76 100644
--- a/crypto/noise.h
+++ b/crypto/noise.h
@@ -81,7 +81,7 @@ bool noise_handle_handshake_response(noise_context_t* ctx,
// used
bool noise_handle_handshake_response_multiple_keys(
noise_context_t* ctx, const curve25519_key initiator_private_key,
- const curve25519_key responder_public_keys[],
+ const curve25519_key* responder_public_keys,
size_t responder_public_keys_count, const noise_response_t* response);
// This is called by both the initiator and responder to send a message
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.