fix(core): setup RGB LED also when PIN not set
What the developer wrote
Authored by obrusvit
fix(core): setup RGB LED also when PIN not set
[no changelog]
What changed, and why it matters
This commit fixes a small inconsistency in the Trezor hardware wallet's startup screen. When a user had not set a PIN, the device's RGB LED (colored status light) was not being configured according to the user's preference. The change makes sure the LED setting is applied in that case too. There is no direct security vulnerability here; it is a user-experience and settings-consistency fix.
No security action required. Treat as a normal bugfix / UX consistency patch.
Security signals we found
No security-relevant signals in the diff or commit message.
Change is a settings-application fix, not a memory-safety, crypto, or authentication change.
Commit title and message do not describe a security issue.
Evidence from the diff
In core/src/boot.py, inside the bootscreen() coroutine, the code that applies user settings (display rotation, haptic feedback) was placed inside a branch that only runs when a PIN is set. The patch adds the same treatment for the RGB LED: when utils.USE_RGB_LED is true, it calls io.rgb_led.rgb_led_set_enabled(storage.device.get_rgb_led()). This ensures the LED preference is honored even when no PIN is configured. The change is two lines and purely functional; it does not alter authentication, cryptography, or memory safety.
Changed components
core/src/boot.pyTrezor Safe series RGB LED initialization at bootInspect captured patch +2 / −0
diff --git a/core/src/boot.py b/core/src/boot.py
index 050107ef..9d1eedfe 100644
--- a/core/src/boot.py
+++ b/core/src/boot.py
@@ -98,6 +98,8 @@ async def bootscreen() -> None:
rotation = storage.device.get_rotation()
if utils.USE_HAPTIC:
io.haptic.haptic_set_enabled(storage.device.get_haptic_feedback())
+ if utils.USE_RGB_LED:
+ io.rgb_led.rgb_led_set_enabled(storage.device.get_rgb_led())
if rotation != ui.display.orientation():
# there is a slight delay before next screen is shown,
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.