AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 37 Bitcoin

feat(core): Evolu key rotation

Public commit record

What the developer wrote

Authored by Martin Pastyřík

72/100 · Adequate
feat(core): Evolu key rotation

Add an index to the generation of Evolu keys and Delegated identity key.

[no changelog]
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
The short version

What changed, and why it matters

This commit adds a key-rotation feature for the 'Evolu' / 'Suite Sync' delegated identity key used by Trezor. It introduces a rotation index that is mixed into the key derivation, lets users rotate the key on demand, and stores the current index in device storage. The change is a feature addition rather than a fix for an obvious vulnerability, but it touches sensitive key-derivation code and adds new protocol messages.

Recommended action

Review the key-derivation change for correctness: ensure the backwards-compatible HMAC diversifier (5 bytes for index 0, 7 bytes otherwise) cannot produce collisions between old and rotated keys. Verify that `EvoluIndexManagement` cannot be abused to downgrade or reset the rotation index, and that the `rotate` and `rotation_index` mutual-exclusion check is enforced in all code paths. Confirm that the new storage field is properly protected and that the THP credential validation path still requires a valid credential before returning any delegated key.

Security signals we found

01

Changes to hardware-backed key derivation (secret_keys)

02

Adds new wire messages for key rotation and index management

03

Adds device-storage field for rotation index

04

Adds user confirmation prompt before key rotation

05

Restricts sign_registration_request to Optiga-enabled builds

06

Renames user-facing strings from secure_sync to suite_sync

Risk score

Why this scored 37/100

Our methodology →
Potential impact 8/30
Exploitability 7/25
Stealth signal 6/15
Affected reach 7/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.