AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 19 Bitcoin

chore: add hardcoded 1inch definitions

Public commit record

What the developer wrote

Authored by Ioan Bizău

80/100 · Strong
chore: add hardcoded 1inch definitions

This reverts commit dc1f3a1b4d81900ab0a406617f5efb7e200df14e but adds
more definitions that what was there.

[no changelog]
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit adds human-readable display definitions for 1inch decentralized-exchange swap transactions on Trezor hardware wallets. It tells the wallet how to decode and label 1inch swap parameters (amounts, beneficiary, last pool) so users can verify what they are signing on the device screen. The change is purely a data/configuration addition plus matching tests; it does not alter cryptographic code, transaction validation, or signing logic. There is no indication in the commit that this fixes a security vulnerability.

Recommended action

No security action required. Review as normal feature/data addition. If auditing, verify that the new 1inch function signatures, address, chain IDs, and field paths match the official 1inch AggregationRouterV6 ABI and the referenced Ledger clear-signing registry.

Security signals we found

01

Adds clear-signing metadata only; no signing or key-management code changed

02

Uses existing parser/formatter primitives; no new parsing logic introduced

03

Function signatures are verified against keccak_32 under __debug__ assertions

04

Native-currency address allowlist is explicitly limited to two known sentinel values

05

Commit message is a routine 'chore' with [no changelog] and no security framing

06

Some test fixtures are hand-assembled/fabricated calldata, but they are test inputs, not runtime definitions

Risk score

Why this scored 19/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 3/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.