CommitWatch RSS
AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 27 Bitcoin

refactor(core/ethereum): handle staking/yielding in `confirm_tx_data()`

TZ6c158b50 View source ↗
Public commit record

What the developer wrote

Authored by Roman Zeyde

85/100 · Strong
refactor(core/ethereum): handle staking/yielding in `confirm_tx_data()`

This way, we don't need to call `get_progress_indicator()`,
since all the data has been already loaded and hashed.

[no changelog]
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This is an internal code cleanup in Trezor's Ethereum transaction signing. It changes how staking and yield-farming transactions hand off their user-confirmation step so the confirmation happens inside the same routine instead of being returned as a separate progress indicator. The commit message says the goal is to avoid needing a progress indicator because all transaction data is already loaded and hashed. There is no direct evidence in the commit of a security bug being fixed, but the change touches the code that decides what users see before they approve high-value operations like staking and vault deposits/withdrawals. The large set of updated UI test hashes shows the on-screen flow changed, which is expected for a refactor of this kind.

Recommended action

Treat as a routine refactor with no immediate security action required. Reviewers should verify that the new await-in-caller pattern does not change the order of data hashing versus user confirmation, and that the removed progress indicator did not provide a security-relevant check (e.g., ensuring additional data chunks are consumed before confirmation). Run the updated UI tests to confirm the new hashes match expected screens.

Security signals we found

01

Refactor of transaction confirmation orchestration for Ethereum staking/yielding

02

Removal of `get_progress_indicator()` usage in staking and yielding paths

03

Return type narrowed from tuple to coroutine, centralizing await in `confirm_tx_data()`

04

Large UI fixture hash churn for staking and vault tests, consistent with visible flow change

05

No explicit security claim, CVE, or advisory in commit message or diff

Risk score

Why this scored 27/100

Our methodology →
Potential impact 5/30
Exploitability 3/25
Stealth signal 4/15
Affected reach 6/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

More from Trezor firmware

Related watches

Informational 18 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core): remove sha1 from regular FW

This commit removes the SHA-1 hashing function from the regular Trezor firmware. SHA-1 is an old, weak hash algorithm that is no longer considered secure for sensitive uses. The change deletes the code that exposes SHA-1 to apps running on…

Removal of a deprecated cryptographic primitive (SHA-1) from the firmware API surfaceReduction of attack surface and prevention of future misuse of a collision-vulnerable hashNo direct vulnerability patch or memory-safety bug is present in the diff
16d15774by M1nd3r+0−2006 files
No security note in commit
Open full analysis →Source commit ↗
Low 27 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): pass static public key to `noise_xxpsk3_*_init()`

This commit changes how a cryptographic library sets up secure connections. Previously, the code automatically calculated the public key from the private key. Now, the caller must provide the public key directly. This is a code-quality ref…

Cryptographic key handling changed: public key is now supplied rather than derivedPotential reduction of key-mismatch risk if caller provides correct public keyNew null-pointer check added for static_public_key
1b3128a4by Ondřej Vejpustek+20−92 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): change order of parameters

This commit simply reorders the arguments of an internal function called dh() and updates every place that calls it. The actual math and security behavior are unchanged; it is a code cleanup with no security effect.

33a119eeby Ondřej Vejpustek+15−151 file
No security note in commit
Open full analysis →Source commit ↗