fix(core): fix rgb_led_effect_ongoing function in unix.
What the developer wrote
Authored by kopecdav
fix(core): fix rgb_led_effect_ongoing function in unix.
[no changelog]
What changed, and why it matters
This is a tiny code cleanup in Trezor's firmware emulator for Unix. It renames one internal function and adds a stub function that always reports 'no LED effect active.' It does not change behavior on real Trezor hardware and does not fix or introduce any security issue.
No security action needed. Treat as routine maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies core/embed/io/rgb_led/unix/rgb_led.c, the Unix emulator implementation of the RGB LED driver. It renames rgb_led_get_effect_ongoing() to rgb_led_effect_ongoing() and adds a new stub rgb_led_effect_get_type() returning RGB_LED_EFFECT_NONE. Both functions are no-ops because RGB LED effects are not supported in the Unix build. The change is purely a build/interface alignment for the emulator target.
Changed components
core/embed/io/rgb_led/unix/rgb_led.cInspect captured patch +6 / −1
diff --git a/core/embed/io/rgb_led/unix/rgb_led.c b/core/embed/io/rgb_led/unix/rgb_led.c
index e2e364ff3..81f8c46ec 100644
--- a/core/embed/io/rgb_led/unix/rgb_led.c
+++ b/core/embed/io/rgb_led/unix/rgb_led.c
@@ -100,9 +100,14 @@ void rgb_led_effect_stop(void) {
return;
}
-bool rgb_led_get_effect_ongoing(void) {
+bool rgb_led_effect_ongoing(void) {
// RGB effect not supported in unix yet
return false;
}
+rgb_led_effect_type_t rgb_led_effect_get_type(void) {
+ // RGB effect not supported in unix yet
+ return RGB_LED_EFFECT_NONE;
+}
+
#endif /* KERNEL_MODE */
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.