test(core): improve input data layout assertion
What the developer wrote
Authored by Roman Zeyde
test(core): improve input data layout assertion
[no changelog]
What changed, and why it matters
This is a minor change to a test helper file that improves how a test checks whether a screen is the 'intro' layout for Ethereum transaction data. It does not change the actual device firmware or any user-facing behavior; it only makes the test assertion more precise. There is no indication this fixes a security issue.
No security action needed. Treat as a normal test-quality improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
Commit 5f6bd555babcd42a41c904e46e34b5925f628e60 modifies tests/input_flows.py. The InputFlowEthereumSignTxData test flow previously assumed the intro layout by checking that the screen content ended with ‘…’. The patch replaces that heuristic with a check that the intro layout contains the ‘view all data’ instruction or button text. This is a test-only refinement and does not alter firmware code, message handling, or UI rendering logic.
Changed components
tests/input_flows.pyInspect captured patch +5 / −3
diff --git a/tests/input_flows.py b/tests/input_flows.py
index 3dc53408..60909c45 100644
--- a/tests/input_flows.py
+++ b/tests/input_flows.py
@@ -1735,9 +1735,11 @@ class InputFlowEthereumSignTxData(InputFlowBase):
layout = self.debug.read_layout()
assert layout.title().startswith(TR.ethereum__title_input_data)
- if is_intro:
- # Intro layout should show a prefix of the data, ending with "..."
- assert layout.screen_content().endswith("...")
+ # Only intro layout contains "view all" functionality:
+ assert is_intro == (
+ TR.instructions__view_all_data in layout.screen_content()
+ or TR.buttons__view_all_data in layout.button_contents()
+ )
if self.scroll:
self._go_to_next_page(is_intro)
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.