refactor(core): avoid calling `workflow.close_others()` twice on `interact`
What the developer wrote
Authored by Roman Zeyde
refactor(core): avoid calling `workflow.close_others()` twice on `interact`
[no changelog]
What changed, and why it matters
This is a small internal cleanup in the Trezor firmware's user-interface code. It removes one of two calls to a function that shuts down other active workflows when a button request is sent. The change is labeled as a refactor with no changelog entry, and there is no direct evidence in the commit that it fixes a security bug.
No immediate security action required. Treat as routine code maintenance. If evaluating for a security advisory, note that the commit itself does not claim to fix a vulnerability and no external security references were provided.
Security signals we found
No security-related keywords in commit title or message
No changelog entry explicitly marked as security-related
Change is a single-line deletion in UI workflow code
No references to vulnerabilities, CVEs, or security reports
Evidence from the diff
The commit removes a workflow.close_others() call from _button_request() in core/src/trezor/ui/layouts/common.py. The title states this avoids calling workflow.close_others() twice on interact, implying the same cleanup is performed elsewhere in the interaction path. The diff is a single deletion with no functional replacement or added safety checks.
Changed components
core/src/trezor/ui/layouts/common.pyInspect captured patch +0 / −1
diff --git a/core/src/trezor/ui/layouts/common.py b/core/src/trezor/ui/layouts/common.py
index bcb68011f..9b1e146d6 100644
--- a/core/src/trezor/ui/layouts/common.py
+++ b/core/src/trezor/ui/layouts/common.py
@@ -26,7 +26,6 @@ async def _button_request(
code: ButtonRequestType = ButtonRequestType.Other,
pages: int = 0,
) -> None:
- workflow.close_others()
if __debug__:
log.info(__name__, "ButtonRequest sent: %s", br_name)
await context.maybe_call(
Why this scored 11/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.