chore(core): correct translation check annotation and docstring
What the developer wrote
Authored by Roman Zeyde
chore(core): correct translation check annotation and docstring
[no changelog]
What changed, and why it matters
This is a tiny documentation-only change. A helper function's type hint was updated from 'bool or None' to just 'bool', and the docstring line saying it could return None when no translation blob exists was removed. No actual code behavior changed, and there is no security relevance.
No action required; this is a non-functional documentation/annotation cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
Commit 554fa2c in core/src/apps/base.py narrows the return annotation of _language_version_matches() from bool | None to bool and removes the corresponding docstring sentence. The diff shows only annotation/docstring changes; no executable logic was modified.
Changed components
core/src/apps/base.pyInspect captured patch +1 / −2
diff --git a/core/src/apps/base.py b/core/src/apps/base.py
index 6a81d47fc..f020a0ee8 100644
--- a/core/src/apps/base.py
+++ b/core/src/apps/base.py
@@ -53,10 +53,9 @@ def busy_expiry_ms() -> int:
return expiry_ms if expiry_ms > 0 else 0
-def _language_version_matches() -> bool | None:
+def _language_version_matches() -> bool:
"""
Whether translation blob version matches firmware version.
- Returns None if there is no blob.
"""
from trezor import translations
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.