What the developer wrote
Authored by Ioan Bizău
fix(eckhart): don't show useless header
[no changelog]
What changed, and why it matters
This is a minor user-interface polish change for the Trezor hardware wallet's Eckhart layout. It hides a redundant header label when the header text is identical to the title text. There is no security relevance in the commit itself or in the supplied references.
No security action needed. Treat as a normal UI cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs. In a UI rendering path it replaces the unconditional use of header with a conditional: if header != title it keeps header, otherwise it uses TString::empty(). This only affects on-screen text display and does not alter security-critical logic, cryptography, memory handling, or trust assumptions.
Changed components
core/embed/rust/src/ui/layout_eckhart/ui_firmware.rsInspect captured patch +5 / −1
diff --git a/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs b/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs
index 413a84f5..dde5b4ef 100644
--- a/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs
+++ b/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs
@@ -1529,7 +1529,11 @@ impl FirmwareUI for UIEckhart {
// subtitle is already quite prominent
&theme::TEXT_SMALL_LIGHT
},
- header,
+ if header != title {
+ header
+ } else {
+ TString::empty()
+ },
)
.no_break();
if !first_item_is_address.unwrap_or(false) {
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.