AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 33 Bitcoin

feat(core): save binary representation of mnemonic in storage for Cardano secret derivation

Public commit record

What the developer wrote

Authored by Martin Pastyřík

62/100 · Adequate
feat(core): save binary representation of mnemonic in storage for Cardano secret derivation

[no changelog]
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
The short version

What changed, and why it matters

This commit changes how Trezor stores wallet backup words (mnemonics) for Cardano support. It now keeps an extra binary copy of the mnemonic in device storage, separate from the encrypted text version. The change is described as a feature, not a security fix. It does not appear to introduce an obvious remote exploit, but it does add a new storage location holding sensitive seed material and includes a debug-only option that lets invalid mnemonics be loaded without raising an error.

Recommended action

Review whether the new `_BINARY_MNEMONIC` field receives the same encryption and access-control protections as `_MNEMONIC_SECRET`. Confirm that the debug-only `allow_derivation_fail` path cannot be reached in production builds. Verify that the Cardano C function `secret_from_entropy_cardano_icarus` correctly bounds-checks the new `binary_mnemonic` length and that the migration cannot be triggered on a locked or partially-initialized device.

Security signals we found

01

New persistent storage field for raw mnemonic entropy+checksum

02

Cardano derivation now consumes binary mnemonic bytes instead of text

03

Storage migration derives and stores binary mnemonic from existing secrets

04

Debug-only `allow_derivation_fail` flag suppresses ValueError for invalid mnemonics

05

No changelog entry despite storage format change

Risk score

Why this scored 33/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 4/15
Affected reach 6/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.