AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 42 Bitcoin

fix(core): remove host static public key from protobuf message

Public commit record

What the developer wrote

Authored by Martin Pastyřík

62/100 · Adequate
fix(core): remove host static public key from protobuf message

[no changelog]
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
The short version

What changed, and why it matters

This commit changes how a Trezor hardware wallet verifies the computer (host) it is talking to when generating a special delegated identity key. Previously, the host had to send its own public key inside the request message, and the device used that key to check a credential. Now the device fetches the host's public key from its own secure channel cache instead. This is a defensive design improvement: it removes an opportunity for a malicious or buggy caller to supply the wrong public key and potentially trick the device into trusting a credential it shouldn't. The commit also adds tests for missing or invalid credentials.

Recommended action

Treat as a hardening/design-cleanup commit rather than an active vulnerability fix. Reviewers should confirm that get_host_static_public_key() is always populated before EvoluGetDelegatedIdentityKey is accepted on a THP channel, and that the channel cache key cannot be influenced by the message sender. No urgent vendor advisory appears required based solely on this diff.

Security signals we found

01

Removal of attacker-controllable public-key field from protobuf message

02

Credential validation now uses channel-cache-derived host static public key

03

Addition of negative tests for invalid/missing credentials

04

Error type changed from ValueError to DataError for malformed/missing inputs

Risk score

Why this scored 42/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 6/15
Affected reach 7/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.