Public commit record
57/100 · Thin
What the developer wrote
Authored by PrisionMike
fix(tron): Use new button request names
[no changelog]
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
What changed, and why it matters
This commit simply renames internal labels used for Tron transaction confirmation screens across different Trezor device layouts. The old names like 'confirm_tron_send' are replaced with newer names like 'tron/send'. There is no visible security change—just keeping naming conventions consistent.
Recommended action
No security action required; treat as routine refactoring/UI consistency update.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch updates button-request (br_name) identifiers for Tron operations from legacy underscore-prefixed strings (‘confirm_tron_freeze_ops’, ‘confirm_tron_send’, ‘confirm_tron_approve’, ‘confirm_tron_transfer’) to a namespaced slash format (‘tron/freeze’, ‘tron/send’, ‘tron/approve’, ‘tron/transfer’) in apps/tron/layout.py and in four UI layout implementations (bolt, caesar, delizia, eckhart). ButtonRequestType values and confirmation logic remain unchanged.
Changed components
core/src/apps/tron/layout.pycore/src/trezor/ui/layouts/bolt/__init__.pycore/src/trezor/ui/layouts/caesar/__init__.pycore/src/trezor/ui/layouts/delizia/__init__.pycore/src/trezor/ui/layouts/eckhart/__init__.pyInspect captured patch +13 / −13
diff --git a/core/src/apps/tron/layout.py b/core/src/apps/tron/layout.py
index 823fe4eb..30056b52 100644
--- a/core/src/apps/tron/layout.py
+++ b/core/src/apps/tron/layout.py
@@ -128,7 +128,7 @@ async def confirm_freeze_operations(
)
await confirm_properties(
- br_name="confirm_tron_freeze_ops",
+ br_name="tron/freeze",
title=TR.words__title_summary,
props=(
(TR.words__amount, format_trx_amount(balance), False),
diff --git a/core/src/trezor/ui/layouts/bolt/__init__.py b/core/src/trezor/ui/layouts/bolt/__init__.py
index 46cae09b..00876352 100644
--- a/core/src/trezor/ui/layouts/bolt/__init__.py
+++ b/core/src/trezor/ui/layouts/bolt/__init__.py
@@ -1494,7 +1494,7 @@ if not utils.BITCOIN_ONLY:
fee=fee or "",
fee_label=TR.words__fee_limit if fee else "",
extra_items=None,
- br_name="confirm_tron_send",
+ br_name="tron/send",
br_code=ButtonRequestType.SignTx,
)
@@ -1506,7 +1506,7 @@ if not utils.BITCOIN_ONLY:
maximum_fee: str,
chunkify: bool = False,
) -> None:
- br_name = "confirm_tron_approve"
+ br_name = "tron/approve"
if is_revoke:
title = TR.ethereum__approve_intro_title_revoke
action_subtitle = TR.ethereum__approve_intro_revoke
@@ -1569,7 +1569,7 @@ if not utils.BITCOIN_ONLY:
maximum_fee: str,
chunkify: bool = True,
) -> None:
- br_name = "confirm_tron_transfer"
+ br_name = "tron/transfer"
title = TR.words__send
await confirm_value(
diff --git a/core/src/trezor/ui/layouts/caesar/__init__.py b/core/src/trezor/ui/layouts/caesar/__init__.py
index ddc39c67..c5b8fa40 100644
--- a/core/src/trezor/ui/layouts/caesar/__init__.py
+++ b/core/src/trezor/ui/layouts/caesar/__init__.py
@@ -1547,7 +1547,7 @@ if not utils.BITCOIN_ONLY:
fee=fee or "",
fee_label=TR.words__fee_limit if fee else "",
),
- br_name="confirm_tron_send",
+ br_name="tron/send",
br_code=ButtonRequestType.SignTx,
)
@@ -1561,7 +1561,7 @@ if not utils.BITCOIN_ONLY:
) -> None:
from ..properties import with_colon
- br_name = "confirm_tron_approve"
+ br_name = "tron/approve"
if is_revoke:
title = TR.ethereum__approve_intro_title_revoke
action_subtitle = TR.ethereum__approve_intro_revoke
@@ -1629,7 +1629,7 @@ if not utils.BITCOIN_ONLY:
) -> None:
from ..properties import with_colon
- br_name = "confirm_tron_transfer"
+ br_name = "tron/transfer"
title = TR.words__send
await confirm_value(
diff --git a/core/src/trezor/ui/layouts/delizia/__init__.py b/core/src/trezor/ui/layouts/delizia/__init__.py
index ba5be0db..14abb23a 100644
--- a/core/src/trezor/ui/layouts/delizia/__init__.py
+++ b/core/src/trezor/ui/layouts/delizia/__init__.py
@@ -1469,7 +1469,7 @@ if not utils.BITCOIN_ONLY:
fee=fee or "",
fee_label=TR.words__fee_limit if fee else "",
extra_items=None,
- br_name="confirm_tron_send",
+ br_name="tron/send",
br_code=ButtonRequestType.SignTx,
)
@@ -1481,7 +1481,7 @@ if not utils.BITCOIN_ONLY:
chunkify: bool = True,
) -> None:
- br_name = "confirm_tron_transfer"
+ br_name = "tron/transfer"
title = TR.words__send
await confirm_value(
@@ -1531,7 +1531,7 @@ if not utils.BITCOIN_ONLY:
chunkify: bool = False,
) -> None:
- br_name = "confirm_tron_approve"
+ br_name = "tron/approve"
if is_revoke:
title = TR.ethereum__approve_intro_title_revoke
action_subtitle = TR.ethereum__approve_intro_revoke
diff --git a/core/src/trezor/ui/layouts/eckhart/__init__.py b/core/src/trezor/ui/layouts/eckhart/__init__.py
index 431afada..0734d4b3 100644
--- a/core/src/trezor/ui/layouts/eckhart/__init__.py
+++ b/core/src/trezor/ui/layouts/eckhart/__init__.py
@@ -1569,7 +1569,7 @@ if not utils.BITCOIN_ONLY:
fee or "",
TR.words__fee_limit if fee else "",
extra_items=None,
- br_name="confirm_tron_send",
+ br_name="tron/send",
br_code=ButtonRequestType.SignTx,
)
@@ -1581,7 +1581,7 @@ if not utils.BITCOIN_ONLY:
chunkify: bool = True,
) -> None:
- br_name = "confirm_tron_transfer"
+ br_name = "tron/transfer"
title = TR.words__send
await confirm_value(
@@ -1631,7 +1631,7 @@ if not utils.BITCOIN_ONLY:
chunkify: bool = True,
) -> None:
- br_name = "confirm_tron_approve"
+ br_name = "tron/approve"
if is_revoke:
title = TR.ethereum__approve_intro_title_revoke
action_subtitle = TR.ethereum__approve_intro_revoke
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.