ci(core): upload artifacts even if build fails
What changed, and why it matters
This is a small GitHub Actions CI workflow change. It tells the workflow to upload build artifacts even when a previous build step fails. This is a normal reliability/debugging improvement and does not change any firmware code, cryptography, or device behavior. There is no security issue visible in this commit.
No security action required. Review as ordinary CI maintenance if desired.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit adds if: always() to the artifact upload step in .github/workflows/common.yml. This GitHub Actions condition causes the upload step to run regardless of earlier job step outcomes. The stated rationale is to preserve unsigned prodtest/bootloader/secmon artifacts when signed secmon artifacts are missing. The change affects CI artifact retention only; no source code, build scripts, signing logic, or runtime behavior is modified.
Changed components
GitHub Actions CI workflow: .github/workflows/common.ymlInspect captured patch +1 / −0
diff --git a/.github/workflows/common.yml b/.github/workflows/common.yml
index aee3add0..0f11e12f 100644
--- a/.github/workflows/common.yml
+++ b/.github/workflows/common.yml
@@ -156,3 +156,4 @@ jobs:
path: |
_artifacts/
retention-days: 7
+ if: always()
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.