test(core): fix `InputFlowEthereumSignTxData` on non-English
What the developer wrote
Authored by Roman Zeyde
test(core): fix `InputFlowEthereumSignTxData` on non-English
[no changelog]
What changed, and why it matters
This is a one-line change to a test helper that checks on-screen text during automated Ethereum transaction signing tests. It switches from checking the full screen content to checking only the visible text content when looking for a 'view all data' instruction. This makes the test work correctly when the device interface language is not English. It does not change any firmware behavior or fix any security issue.
No security action needed. This is a normal test-maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In tests/input_flows.py, the InputFlowEthereumSignTxData class assertion that detects whether the current layout is the intro screen was updated from layout.screen_content() to layout.text_content(). The former apparently includes non-text elements that can differ across locales, causing false negatives in non-English language tests. The change is purely a test robustness fix and has no effect on device firmware, cryptography, UI rendering, or transaction validation.
Changed components
tests/input_flows.pyInspect captured patch +1 / −1
diff --git a/tests/input_flows.py b/tests/input_flows.py
index 60909c45..bfb71ee3 100644
--- a/tests/input_flows.py
+++ b/tests/input_flows.py
@@ -1737,7 +1737,7 @@ class InputFlowEthereumSignTxData(InputFlowBase):
# Only intro layout contains "view all" functionality:
assert is_intro == (
- TR.instructions__view_all_data in layout.screen_content()
+ TR.instructions__view_all_data in layout.text_content()
or TR.buttons__view_all_data in layout.button_contents()
)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.