ci: hw: don't run core tests if only T1B1 is chosen
What changed, and why it matters
This is a minor GitHub Actions CI workflow tweak. It prevents certain hardware test jobs from running when no 'core' device models are selected (for example, when only the older T1B1 model is chosen). It does not change any firmware code, cryptography, or device behavior, and has no direct security relevance for Trezor users.
No security action required. This is a routine CI optimization.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies .github/workflows/core-hw.yml, adding a conditional if: needs.param.outputs.core_models != '[]' to two hardware test jobs. This skips those jobs when the selected model matrix is empty, avoiding wasted CI runs when only T1B1 (a legacy model not covered by these core jobs) is chosen. The second job remains permanently disabled via && false due to an existing FIXME referencing issue #3128.
Changed components
.github/workflows/core-hw.ymlInspect captured patch +2 / −1
diff --git a/.github/workflows/core-hw.yml b/.github/workflows/core-hw.yml
index 1de73df0..dbed2c7a 100644
--- a/.github/workflows/core-hw.yml
+++ b/.github/workflows/core-hw.yml
@@ -57,6 +57,7 @@ jobs:
- self-hosted
# FIXME runner4 with t2b1 does not work at the moment
- ${{ matrix.model == 'T2B1' && 'runner3' || matrix.model == 'T3T1' && 'hw-t3t1' || matrix.model == 'T3B1' && 'hw-t3b1' || matrix.model == 'T3W1' && 'hw-t3w1' || 'hw-t2t1' }}
+ if: needs.param.outputs.core_models != '[]'
strategy:
fail-fast: false
matrix:
@@ -117,7 +118,7 @@ jobs:
- self-hosted
# FIXME runner4 with t2b1 does not work at the moment
- ${{ matrix.model == 'T2B1' && 'runner3' || matrix.model == 'T3T1' && 'hw-t3t1' || matrix.model == 'T3B1' && 'hw-t3b1' || matrix.model == 'T3W1' && 'hw-t3w1' || 'hw-t2t1' }}
- if: false # FIXME https://github.com/trezor/trezor-firmware/issues/3128
+ if: needs.param.outputs.core_models != '[]' && false # FIXME https://github.com/trezor/trezor-firmware/issues/3128
strategy:
fail-fast: false
matrix:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.