CommitWatch RSS
AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 21 Bitcoin

feat(core): allow `WebAuthnListResidentCredentials` pagination

TZ1e319b3b View source ↗
Public commit record

What the developer wrote

Authored by Roman Zeyde

62/100 · Adequate
feat(core): allow `WebAuthnListResidentCredentials` pagination
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
The short version

What changed, and why it matters

This commit adds pagination support for listing WebAuthn (FIDO2) resident credentials stored on a Trezor device. Previously, the device returned all credentials in one message, which could hit size limits. Now the host can request credentials in smaller batches. There is no obvious security bug in the change; it is a feature addition with a small, well-scoped protocol change.

Recommended action

No immediate security action required. As a defensive review, verify that the wire message parser enforces an upper bound on `batch_size` elsewhere in the codebase to avoid accidental oversized responses, and confirm that the host-side loop cannot be induced into an unbounded exchange by a malicious or compromised device.

Security signals we found

01

New wire protocol flow using `context.call` with `WebAuthnCredentialsAck` response expected

02

Input validation added for `batch_size <= 0`

03

No validation or limits on maximum `batch_size` observed in diff

04

No authorization or confirmation changes beyond existing `confirm_action`

05

Feature is additive and preserves non-paginated API path

Risk score

Why this scored 21/100

Our methodology →
Potential impact 2/30
Exploitability 2/25
Stealth signal 2/15
Affected reach 3/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

More from Trezor firmware

Related watches

Informational 18 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core): remove sha1 from regular FW

This commit removes the SHA-1 hashing function from the regular Trezor firmware. SHA-1 is an old, weak hash algorithm that is no longer considered secure for sensitive uses. The change deletes the code that exposes SHA-1 to apps running on…

Removal of a deprecated cryptographic primitive (SHA-1) from the firmware API surfaceReduction of attack surface and prevention of future misuse of a collision-vulnerable hashNo direct vulnerability patch or memory-safety bug is present in the diff
16d15774by M1nd3r+0−2006 files
No security note in commit
Open full analysis →Source commit ↗
Low 27 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): pass static public key to `noise_xxpsk3_*_init()`

This commit changes how a cryptographic library sets up secure connections. Previously, the code automatically calculated the public key from the private key. Now, the caller must provide the public key directly. This is a code-quality ref…

Cryptographic key handling changed: public key is now supplied rather than derivedPotential reduction of key-mismatch risk if caller provides correct public keyNew null-pointer check added for static_public_key
1b3128a4by Ondřej Vejpustek+20−92 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): change order of parameters

This commit simply reorders the arguments of an internal function called dh() and updates every place that calls it. The actual math and security behavior are unchanged; it is a code cleanup with no security effect.

33a119eeby Ondřej Vejpustek+15−151 file
No security note in commit
Open full analysis →Source commit ↗