test(core): fix InputFlowEthereumSignTxData assertion for Eckhart
What the developer wrote
Authored by Roman Zeyde
test(core): fix InputFlowEthereumSignTxData assertion for Eckhart
[no changelog]
What changed, and why it matters
This is a tiny test-only change that fixes an assertion in an automated UI test for Ethereum transaction signing. It makes the test check the screen title more consistently across different Trezor device models. There is no change to the actual firmware code that runs on the device, so it cannot affect real users or their crypto assets.
No security action needed. This is a routine test fix and can be reviewed as normal QA.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies tests/input_flows.py, specifically InputFlowEthereumSignTxData. It removes a special-case branch for LayoutType.Eckhart that used a regex against a translated string template, and replaces it with a single assertion that layout.title().startswith(TR.ethereum__title_input_data). This is purely a test helper/expectation adjustment; no device firmware, signing logic, or cryptographic code is changed.
Changed components
tests/input_flows.pyInspect captured patch +1 / −6
diff --git a/tests/input_flows.py b/tests/input_flows.py
index 804bd616..3dc53408 100644
--- a/tests/input_flows.py
+++ b/tests/input_flows.py
@@ -1733,12 +1733,7 @@ class InputFlowEthereumSignTxData(InputFlowBase):
assert confirm_tx is None
layout = self.debug.read_layout()
- if self.client.layout_type is LayoutType.Eckhart:
- TR.regexp("ethereum__title_all_input_data_template").fullmatch(
- layout.title().strip()
- )
- else:
- assert TR.ethereum__title_input_data in layout.title()
+ assert layout.title().startswith(TR.ethereum__title_input_data)
if is_intro:
# Intro layout should show a prefix of the data, ending with "..."
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.