What changed, and why it matters
This commit is a routine internal CI (Continuous Integration) maintenance change. It updates two GitHub workflow files so that a script which downloads old Trezor emulators for upgrade testing receives the correct device model parameter. There is no change to the firmware code that runs on user devices, no change to cryptographic operations, and no indication of any security bug being fixed.
No security action required. This is a normal CI chore commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies .github/workflows/core.yml and .github/workflows/legacy.yml. In core.yml, the call to tests/download_emulators.sh is changed to pass ${{ matrix.model }}. In legacy.yml, it is changed to pass the literal T1B1. This is purely a CI pipeline adjustment to ensure the correct old emulator binaries are fetched for matrix-based upgrade tests. No firmware source, build artifacts shipped to users, or security-sensitive logic is altered.
Changed components
.github/workflows/core.yml.github/workflows/legacy.ymlInspect captured patch +2 / −2
diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml
index f91c1519f..04c1f47d7 100644
--- a/.github/workflows/core.yml
+++ b/.github/workflows/core.yml
@@ -399,7 +399,7 @@ jobs:
path: core/build
- run: chmod +x core/build/unix/trezor-emu-core*
- uses: ./.github/actions/environment
- - run: nix-shell --run "tests/download_emulators.sh"
+ - run: nix-shell --run "tests/download_emulators.sh ${{ matrix.model }}"
- run: nix-shell --run "uv run pytest tests/upgrade_tests"
- uses: actions/upload-artifact@v4
with:
diff --git a/.github/workflows/legacy.yml b/.github/workflows/legacy.yml
index e2ba29088..b7f807d53 100644
--- a/.github/workflows/legacy.yml
+++ b/.github/workflows/legacy.yml
@@ -175,7 +175,7 @@ jobs:
path: legacy/firmware
- run: chmod +x legacy/firmware/*.elf
- uses: ./.github/actions/environment
- - run: nix-shell --run "tests/download_emulators.sh"
+ - run: nix-shell --run "tests/download_emulators.sh T1B1"
- run: nix-shell --run "uv run pytest tests/upgrade_tests"
legacy_hwi_test:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.