CommitWatch RSS
AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 44 Monero

Merge pull request #1437 from cypherstack/julian/various-fixes-contd

SWae6a439d View source ↗
Public commit record

What the developer wrote

Authored by Julian

58/100 · Thin
Merge pull request #1437 from cypherstack/julian/various-fixes-contd

Julian/various fixes contd
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This is a very large routine merge of 'various fixes' for the Stack Wallet Flutter app. The visible changes mostly update build tooling (Flutter 3.47.2, Android Gradle Plugin 9, Go/Rust versions), switch several crypto plugins from Git submodules to native-assets/prebuilt builds, reformat code, regenerate Isar database schema files, and fix a handful of UI/amount-handling bugs. There is no explicit security disclosure in the commit message or diff, and no single clearly exploitable vulnerability is introduced. The most security-relevant code-level changes are hardening touches: Android secure-storage options now disable reset-on-error and enable backup migration, ElectrumX ping now returns false on timeout instead of throwing, and MWEB peg-out UTXOs now enforce an extra maturity check before being considered spendable. However, the patch is huge (234 files, thousands of lines changed), so a complete security review is not possible from the supplied excerpt alone.

Recommended action

Treat this as a routine maintenance merge rather than an emergency security patch. Because the change set is enormous and touches build tooling, native plugins, database schemas, and financial UI code, reviewers should: (1) verify the new pinned prebuilt native-asset hashes/sources for flutter_libepiccash and flutter_libmwc match expected upstream releases; (2) run the expanded test suite (many new tests are included) and confirm no regressions in amount parsing, exchange quoting, or UTXO selection; (3) validate the Android secure-storage migration behavior on devices with backup/restore; (4) review the full diff for any additional security-relevant changes not visible in the excerpt; (5) if this is being backported or released, request a changelog/security note from the vendor because the commit title gives no indication of security fixes.

Security signals we found

01

Android secure storage options changed to resetOnError: false and migrateWithBackup: true

02

ElectrumX ping timeout now returns false instead of leaving a dangling future/throw

03

MWEB peg-out UTXOs now require an additional maturity block count before being spendable

04

Large amount-parsing refactor replacing Decimal.tryParse with locale-aware Amount.tryParseEditableAmount

05

Isar schema version bump across many generated files

06

Crypto plugins moved from submodules to pinned prebuilts/native-assets (supply-chain/build-integrity change)

07

CakePay order view copy button target changed from orderId to selected.address

Risk score

Why this scored 44/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 6/15
Affected reach 10/15
Confidence 5/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

More from Stack Wallet

Related watches

Informational 19 AI analysisMessage 73 · Adequate
SW Stack WalletStack Wallet MoneroPrivacy protocolsSoftware wallets

Merge pull request #1361 from cypherstack/fix/305-multiline-transaction-notes

This commit lets users type multi-line notes when editing transaction and trade notes, and fixes the desktop layout so long notes scroll instead of breaking the screen. It also swaps the old `mounted` check for the newer `context.mounted` …

5172e63eby Julian+402−1113 files
No security note in commit
Open full analysis →Source commit ↗
Low 32 AI analysisMessage 50 · Thin
SW Stack WalletStack Wallet MoneroPrivacy protocolsSoftware wallets

Merge branch 'staging' into fix/305-multiline-transaction-notes

This commit is a large merge that mainly removes old integration tests and adds new desktop 'forgot password' reset tests. It also adds a safe-shutdown path for background Firo cache workers and databases. The changes look like defensive h…

Added safe shutdown of Firo cache isolates/SQLite databases before reset exitNew integration tests verify desktop forgot-password reset deletes secrets and preserves backupsTest harness intercepts exit() and IOOverrides to observe reset side effects
21491edbby Julian+2352−319075 files
No security note in commit
Open full analysis →Source commit ↗
Moderate 57 AI analysisMessage 73 · Adequate
SW Stack WalletStack Wallet MoneroPrivacy protocolsSoftware wallets

Merge pull request #1455 from cypherstack/fix/desktop-pw-reset

This commit fixes the desktop "forgot password" reset flow in Stack Wallet. It adds integration tests that verify the app can securely wipe its own data when a user forgets the desktop password, and it updates the Firo cache worker to clos…

Desktop password reset now closes Firo cache workers and SQLite databases before deleting app data, reducing the risk of data leakage or corruption during wipeNew integration tests assert that a successful reset removes password store (hive/desktopdata.hive), wallet key store (isar/desktopStore.isar), and wallet files while preserving backups and tor stateFailed reset scenario leaves a .reset-pending marker and removes password/key stores first, preventing the reset from being undone after partial deletion
055e6c6bby Julian+1077−297154 files
No security note in commit
Open full analysis →Source commit ↗