What the developer wrote
Authored by Hector Chu
Fix mweb fee override propagation
What changed, and why it matters
This commit fixes a bug where a user-specified custom fee amount was not being passed along when building Mimblewimble (MWEB) transactions in the Stack Wallet app. Without the fix, the wallet could ignore the user's fee choice and use a default or calculated fee instead, potentially leading to unexpected transaction costs or failed transactions.
Review the MWEB transaction builder to confirm overrideFeeAmount is now consumed correctly end-to-end, and add regression tests covering custom fee scenarios for MWEB sends. Verify no other fee-related parameters are similarly dropped in adjacent code paths.
Security signals we found
Fee override parameter not propagated to MWEB transaction builder
Potential user-expected fee mismatch in privacy-focused MWEB transactions
Single-line omission fix with no broader refactoring
Evidence from the diff
In lib/wallets/wallet/wallet_mixin_interfaces/electrumx_interface.dart, the overrideFeeAmount parameter was omitted when calling the MWEB transaction-building helper. The one-line patch adds overrideFeeAmount: overrideFeeAmount to propagate the caller’s fee override into the MWEB coin selection/fee computation path. This is a correctness fix for fee handling in MWEB sends.
Changed components
lib/wallets/wallet/wallet_mixin_interfaces/electrumx_interface.dartMWEB (Mimblewimble Extension Block) transaction constructionElectrumX-based wallet interfaceInspect captured patch +1 / −0
diff --git a/lib/wallets/wallet/wallet_mixin_interfaces/electrumx_interface.dart b/lib/wallets/wallet/wallet_mixin_interfaces/electrumx_interface.dart
index 17120df..26106e6 100644
--- a/lib/wallets/wallet/wallet_mixin_interfaces/electrumx_interface.dart
+++ b/lib/wallets/wallet/wallet_mixin_interfaces/electrumx_interface.dart
@@ -405,6 +405,7 @@ mixin ElectrumXInterface<T extends ElectrumXCurrencyInterface>
utxos: utxos,
coinControl: coinControl,
isSendAllCoinControlUtxos: isSendAllCoinControlUtxos,
+ overrideFeeAmount: overrideFeeAmount,
);
}
throw Exception("Insufficient balance to pay transaction fee");
Why this scored 46/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.