← Watch feed
fix: remove tokenTicker param from DesktopAuthSend call
Public commit record
62/100 · Adequate
What the developer wrote
Authored by sneurlax
fix: remove tokenTicker param from DesktopAuthSend call
and use ticker symbol
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
What changed, and why it matters
This commit changes a desktop cryptocurrency wallet's send confirmation dialog so it can display a custom token ticker (for tokens built on a coin) instead of always showing the base coin's ticker. The title says it removes a tokenTicker parameter, but the code actually adds one. The change is mostly a UI label fix and does not appear to alter how transactions are authorized, signed, or sent.
Recommended action
No security action required. Treat as a normal UI/UX fix. If reviewing, verify that callers pass tokenTicker correctly for token wallets and that the fallback to coin.ticker is acceptable for non-token coins.
Security signals we found
01
UI label correction only
02
No change to authentication or signing flow
03
No input validation changes
04
No network or crypto primitive changes
Evidence from the diff
DesktopAuthSend now accepts an optional String? tokenTicker. The confirmation prompt text uses widget.tokenTicker?.toUpperCase() ?? widget.coin.ticker.toUpperCase(), so ERC-20/SLP/etc. tokens display their own symbol rather than the parent chain’s ticker. The rest of the diff is formatting and widget cleanup. No logic affecting password validation, transaction construction, or signing was modified.
Changed components
lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_auth_send.dartInspect captured patch +49 / −82
diff --git a/lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_auth_send.dart b/lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_auth_send.dart
index c38b33a..242e71e 100644
--- a/lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_auth_send.dart
+++ b/lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_auth_send.dart
@@ -26,12 +26,10 @@ import '../../../../widgets/loading_indicator.dart';
import '../../../../widgets/stack_text_field.dart';
class DesktopAuthSend extends ConsumerStatefulWidget {
- const DesktopAuthSend({
- super.key,
- required this.coin,
- });
+ const DesktopAuthSend({super.key, required this.coin, this.tokenTicker});
final CryptoCurrency coin;
+ final String? tokenTicker;
@override
ConsumerState<DesktopAuthSend> createState() => _DesktopAuthSendState();
@@ -59,12 +57,7 @@ class _DesktopAuthSendState extends ConsumerState<DesktopAuthSend> {
builder: (context) => const Column(
mainAxisAlignment: MainAxisAlignment.center,
crossAxisAlignment: CrossAxisAlignment.center,
- children: [
- LoadingIndicator(
- width: 200,
- height: 200,
- ),
- ],
+ children: [LoadingIndicator(width: 200, height: 200)],
),
),
);
@@ -77,15 +70,8 @@ class _DesktopAuthSendState extends ConsumerState<DesktopAuthSend> {
if (mounted) {
Navigator.of(context).pop();
- Navigator.of(
- context,
- rootNavigator: true,
- ).pop(passwordIsValid);
- await Future<void>.delayed(
- const Duration(
- milliseconds: 100,
- ),
- );
+ Navigator.of(context, rootNavigator: true).pop(passwordIsValid);
+ await Future<void>.delayed(const Duration(milliseconds: 100));
}
} finally {
_lock = false;
@@ -113,29 +99,17 @@ class _DesktopAuthSendState extends ConsumerState<DesktopAuthSend> {
return Column(
mainAxisSize: MainAxisSize.min,
children: [
- SvgPicture.asset(
- Assets.svg.keys,
- width: 100,
- ),
- const SizedBox(
- height: 56,
- ),
+ SvgPicture.asset(Assets.svg.keys, width: 100),
+ const SizedBox(height: 56),
+ Text("Confirm transaction", style: STextStyles.desktopH3(context)),
+ const SizedBox(height: 16),
Text(
- "Confirm transaction",
- style: STextStyles.desktopH3(context),
- ),
- const SizedBox(
- height: 16,
- ),
- Text(
- "Enter your wallet password to send ${widget.coin.ticker.toUpperCase()}",
+ "Enter your wallet password to send ${widget.tokenTicker?.toUpperCase() ?? widget.coin.ticker.toUpperCase()}",
style: STextStyles.desktopTextMedium(context).copyWith(
color: Theme.of(context).extension<StackColors>()!.textDark3,
),
),
- const SizedBox(
- height: 24,
- ),
+ const SizedBox(height: 24),
ClipRRect(
borderRadius: BorderRadius.circular(
Constants.size.circularBorderRadius,
@@ -144,9 +118,7 @@ class _DesktopAuthSendState extends ConsumerState<DesktopAuthSend> {
key: const Key("desktopLoginPasswordFieldKey"),
focusNode: passwordFocusNode,
controller: passwordController,
- style: STextStyles.desktopTextMedium(context).copyWith(
- height: 2,
- ),
+ style: STextStyles.desktopTextMedium(context).copyWith(height: 2),
obscureText: hidePassword,
enableSuggestions: false,
autocorrect: false,
@@ -156,45 +128,44 @@ class _DesktopAuthSendState extends ConsumerState<DesktopAuthSend> {
_confirmPressed();
}
},
- decoration: standardInputDecoration(
- "Enter password",
- passwordFocusNode,
- context,
- ).copyWith(
- suffixIcon: UnconstrainedBox(
- child: SizedBox(
- height: 70,
- child: Row(
- children: [
- const SizedBox(
- width: 24,
- ),
- GestureDetector(
- key: const Key(
- "restoreFromFilePasswordFieldShowPasswordButtonKey",
- ),
- onTap: () async {
- setState(() {
- hidePassword = !hidePassword;
- });
- },
- child: SvgPicture.asset(
- hidePassword ? Assets.svg.eye : Assets.svg.eyeSlash,
- color: Theme.of(context)
- .extension<StackColors>()!
- .textDark3,
- width: 24,
- height: 24,
- ),
+ decoration:
+ standardInputDecoration(
+ "Enter password",
+ passwordFocusNode,
+ context,
+ ).copyWith(
+ suffixIcon: UnconstrainedBox(
+ child: SizedBox(
+ height: 70,
+ child: Row(
+ children: [
+ const SizedBox(width: 24),
+ GestureDetector(
+ key: const Key(
+ "restoreFromFilePasswordFieldShowPasswordButtonKey",
+ ),
+ onTap: () async {
+ setState(() {
+ hidePassword = !hidePassword;
+ });
+ },
+ child: SvgPicture.asset(
+ hidePassword
+ ? Assets.svg.eye
+ : Assets.svg.eyeSlash,
+ color: Theme.of(
+ context,
+ ).extension<StackColors>()!.textDark3,
+ width: 24,
+ height: 24,
+ ),
+ ),
+ const SizedBox(width: 12),
+ ],
),
- const SizedBox(
- width: 12,
- ),
- ],
+ ),
),
),
- ),
- ),
onChanged: (newValue) {
setState(() {
_confirmEnabled = passwordController.text.isNotEmpty;
@@ -202,9 +173,7 @@ class _DesktopAuthSendState extends ConsumerState<DesktopAuthSend> {
},
),
),
- const SizedBox(
- height: 48,
- ),
+ const SizedBox(height: 48),
Row(
children: [
Expanded(
@@ -214,9 +183,7 @@ class _DesktopAuthSendState extends ConsumerState<DesktopAuthSend> {
onPressed: Navigator.of(context).pop,
),
),
- const SizedBox(
- width: 16,
- ),
+ const SizedBox(width: 16),
Expanded(
child: PrimaryButton(
enabled: _confirmEnabled,
Risk score
Our methodology →Why this scored 16/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.