load jzbar native dependencies explicitly
What the developer wrote
Authored by Craig Raw
load jzbar native dependencies explicitly
What changed, and why it matters
This commit changes how the Sparrow Wallet desktop app loads a native library used for scanning QR codes (ZBar). Previously it only loaded zbar.dll directly. Now, on Windows, it first tries to load iconv-2.dll, a helper library that zbar.dll depends on, before loading zbar.dll itself. This is a dependency-loading fix, not a clear security patch. It may prevent crashes or missing-library errors when scanning QR codes on Windows, but the diff alone does not show a vulnerability being fixed.
Treat as a routine compatibility/stability fix. No urgent security action is indicated by the commit alone. If maintaining a fork, verify that iconv-2.dll is bundled legitimately and that System.load paths are not attacker-controllable (e.g., java.home is not writable by untrusted users).
Security signals we found
Native library loading changed (System.load)
Dependency loading order modified
No explicit security context in commit message or diff
Evidence from the diff
The patch modifies ZBar.java to explicitly load iconv-2.dll before loading the zbar native library. On Windows, native DLLs often fail to load if their runtime dependencies are not already loaded or available in the search path. By calling System.load(iconvFile.getAbsolutePath()) conditionally, the code ensures the iconv dependency is present in the process before zbar is loaded. There is no evidence in the commit message or diff of a security flaw, exploit, or disclosure.
Changed components
src/main/java/com/sparrowwallet/sparrow/io/ZBar.javaWindows ZBar QR code scanning integrationInspect captured patch +6 / −1
diff --git a/src/main/java/com/sparrowwallet/sparrow/io/ZBar.java b/src/main/java/com/sparrowwallet/sparrow/io/ZBar.java
index 2315fac..87197d6 100644
--- a/src/main/java/com/sparrowwallet/sparrow/io/ZBar.java
+++ b/src/main/java/com/sparrowwallet/sparrow/io/ZBar.java
@@ -24,7 +24,12 @@ public class ZBar {
if(!zbarLoaded) {
String javaHome = System.getProperty("java.home");
if(javaHome != null) {
- File libFile = new File(javaHome, "lib" + java.io.File.separator + System.mapLibraryName("zbar"));
+ File libDir = new File(javaHome, "lib");
+ File iconvFile = new File(libDir, "iconv-2.dll");
+ if(iconvFile.exists()) {
+ System.load(iconvFile.getAbsolutePath());
+ }
+ File libFile = new File(libDir, System.mapLibraryName("zbar"));
if(libFile.exists()) {
System.load(libFile.getAbsolutePath());
}
Why this scored 27/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.