focus test connection after editing it, keep one tab stop for the message format and name each exclude utxo button
What changed, and why it matters
This commit makes three small user-interface polish fixes: it moves keyboard focus to the 'Test Connection' button after editing a server connection, restores a single Tab-key stop for message-format toggle buttons, and gives each 'Exclude UTXO' button a unique screen-reader name that includes the specific UTXO description. None of these changes are security fixes; they are accessibility and usability improvements.
No security action needed. Treat as a normal usability/accessibility commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff contains three unrelated UI tweaks. (1) ServerSettingsController: after the user clicks ‘Edit Connection’, that button is hidden and ‘Test Connection’ is shown; the patch calls requestFocus() on testConnection so focus does not fall to the dialog’s Close button. (2) MessageSignDialog: the segmented format buttons are explicitly joined to the toggle group before the skin’s listener is created, preserving a single Tab stop behavior. (3) TransactionDiagram: each per-input ‘Exclude UTXO’ button gets an accessibleText that includes the UTXO description (‘Exclude UTXO ’ + desc) instead of a generic label. No cryptographic, networking, or privilege logic is changed.
Changed components
MessageSignDialog UITransactionDiagram UIServerSettingsController UIInspect captured patch +10 / −2
### src/main/java/com/sparrowwallet/sparrow/control/MessageSignDialog.java
@@ -188,7 +188,12 @@ public MessageSignDialog(Wallet wallet, WalletNode walletNode, String title, Str
formatBip322 = new ToggleButton("BIP322 (Simple)");
SegmentedButton formatButtons = new SegmentedButton(formatElectrum, formatTrezor, formatBip322);
formatButtons.setToggleGroup(formatGroup);
- formatButtons.getButtons().forEach(button -> button.setAccessibleRole(AccessibleRole.RADIO_BUTTON));
+ //The skin only puts the buttons in the group when it is created, after the group listener below that restores a cleared selection.
+ //Joining it now keeps each button's Tab stop listener ahead of that one, so a restored selection leaves one Tab stop as before.
+ formatButtons.getButtons().forEach(button -> {
+ button.setToggleGroup(formatGroup);
+ button.setAccessibleRole(AccessibleRole.RADIO_BUTTON);
+ });
formatField.getInputs().add(formatButtons);
fieldset.getChildren().addAll(addressField, messageField, signatureField, formatField);
### src/main/java/com/sparrowwallet/sparrow/control/TransactionDiagram.java
@@ -460,7 +460,8 @@ private Pane getInputsLabels(List<Map<BlockTransactionHashIndex, WalletNode>> di
Button excludeUtxoButton = new Button("");
excludeUtxoButton.setGraphic(getExcludeGlyph());
- excludeUtxoButton.setAccessibleText("Exclude UTXO");
+ //Named with the UTXO shown beside it, as each input has one of these buttons
+ excludeUtxoButton.setAccessibleText("Exclude UTXO " + desc);
excludeUtxoButton.setOnAction(event -> {
EventManager.get().post(new ExcludeUtxoEvent(walletTx, input));
});
### src/main/java/com/sparrowwallet/sparrow/settings/ServerSettingsController.java
@@ -457,6 +457,8 @@ public void initializeView(Config config) {
setFieldsEditable(true);
editConnection.setVisible(false);
testConnection.setVisible(true);
+ //The button pressed is hidden, so focus moves to the one that takes its place rather than falling to the dialog's Close button
+ testConnection.requestFocus();
});
PublicElectrumServer configPublicElectrumServer = PublicElectrumServer.fromServer(config.getPublicElectrumServer());Why this scored 20/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.