allow transaction diagram input and output labels to expand into available width

Sparrow/Sparrow Wallet

e8c56608 View source ↗

Public commit record

What the developer wrote

Authored by Craig Raw

50/100 · Thin

allow transaction diagram input and output labels to expand into available width

✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body

The short version

What changed, and why it matters

This commit is a user-interface layout tweak for Sparrow Wallet. It lets the transaction diagram's input and output labels use more horizontal space so long text (such as addresses or labels) is easier to read. There is no security change here.

Recommended action

No security action needed; treat as a normal UI improvement.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The patch modifies TransactionDiagram.java and two FXML files to replace fixed widths with GridPane column constraints that grow with available space. It removes hardcoded max/pref widths on input/output label boxes and on the diagram controls in headers.fxml and send.fxml. The expanded-diagram popup now sizes itself based on the active window width rather than a fixed 600 px. These are purely cosmetic/layout changes.

Changed components

com.sparrowwallet.sparrow.control.TransactionDiagramtransaction/headers.fxmlwallet/send.fxml

Inspect captured patch +39 / −8

diff --git a/src/main/java/com/sparrowwallet/sparrow/control/TransactionDiagram.java b/src/main/java/com/sparrowwallet/sparrow/control/TransactionDiagram.java
index 7becb2d..e19b37c 100644
--- a/src/main/java/com/sparrowwallet/sparrow/control/TransactionDiagram.java
+++ b/src/main/java/com/sparrowwallet/sparrow/control/TransactionDiagram.java
@@ -24,6 +24,7 @@ import javafx.beans.property.SimpleBooleanProperty;
 import javafx.beans.property.SimpleObjectProperty;
 import javafx.embed.swing.SwingFXUtils;
 import javafx.event.EventHandler;
+import javafx.geometry.HPos;
 import javafx.geometry.Insets;
 import javafx.geometry.Pos;
 import javafx.scene.Group;
@@ -105,6 +106,7 @@ public class TransactionDiagram extends GridPane {
                 expandedDiagram.setId("transactionDiagram");
                 expandedDiagram.setExpanded(true);
                 expandedDiagram.setFinal(isFinal());
+                expandedDiagram.setMaxWidth(AppServices.getActiveWindow().getWidth() - 200);
                 updateDerivedDiagram(expandedDiagram);
 
                 HBox buttonBox = new HBox();
@@ -122,7 +124,7 @@ public class TransactionDiagram extends GridPane {
                 AppServices.setStageIcon(stage);
                 stage.setScene(scene);
                 stage.setOnShowing(e -> {
-                    AppServices.moveToActiveWindowScreen(stage, 600, 460);
+                    AppServices.moveToActiveWindowScreen(stage, expandedDiagram.getMaxWidth(), 460);
                 });
                 stage.setOnHidden(e -> {
                     expandedDiagram = null;
@@ -139,6 +141,39 @@ public class TransactionDiagram extends GridPane {
         }
     };
 
+    public TransactionDiagram() {
+        ColumnConstraints col1 = new ColumnConstraints();
+        col1.setPrefWidth(22);
+        col1.setHgrow(Priority.NEVER);
+
+        ColumnConstraints col2 = new ColumnConstraints();
+        col2.setHgrow(Priority.ALWAYS);
+        col2.setPercentWidth(25);
+        col2.setFillWidth(true);
+
+        ColumnConstraints col3 = new ColumnConstraints();
+        col3.setPrefWidth(140);
+        col3.setHgrow(Priority.NEVER);
+
+        ColumnConstraints col4 = new ColumnConstraints();
+        Label label = new Label();
+        col4.setMinWidth(TextUtils.computeTextWidth(label.getFont(), "Transaction", 0) + 20);
+        col4.setHgrow(Priority.NEVER);
+        col4.setHalignment(HPos.CENTER);
+
+        ColumnConstraints col5 = new ColumnConstraints();
+        col5.setPrefWidth(140);
+        col5.setHgrow(Priority.NEVER);
+
+        ColumnConstraints col6 = new ColumnConstraints();
+        col6.setHgrow(Priority.ALWAYS);
+        col6.setPercentWidth(25);
+        col6.setFillWidth(true);
+
+        getColumnConstraints().addAll(col1, col2, col3, col4, col5, col6);
+        setPadding(new Insets(0, 0, 0, 40));
+    }
+
     public void update(WalletTransaction walletTx) {
         setMinHeight(getDiagramHeight());
         setMaxHeight(getDiagramHeight());
@@ -410,8 +445,6 @@ public class TransactionDiagram extends GridPane {
 
     private Pane getInputsLabels(List<Map<BlockTransactionHashIndex, WalletNode>> displayedUtxoSets) {
         VBox inputsBox = new VBox();
-        inputsBox.setMaxWidth(isExpanded() ? 300 : 150);
-        inputsBox.setPrefWidth(isExpanded() ? 230 : 150);
         inputsBox.setPadding(new Insets(0, 10, 0, 10));
         inputsBox.minHeightProperty().bind(minHeightProperty());
         inputsBox.setAlignment(Pos.BASELINE_RIGHT);
@@ -679,8 +712,6 @@ public class TransactionDiagram extends GridPane {
 
     private Pane getOutputsLabels(List<Payment> displayedPayments) {
         VBox outputsBox = new VBox();
-        outputsBox.setMaxWidth(isExpanded() ? 350 : 150);
-        outputsBox.setPrefWidth(isExpanded() ? 230 : 150);
         outputsBox.setPadding(new Insets(0, 20, 0, 10));
         outputsBox.setAlignment(Pos.BASELINE_LEFT);
         outputsBox.getChildren().add(createSpacer());
diff --git a/src/main/resources/com/sparrowwallet/sparrow/transaction/headers.fxml b/src/main/resources/com/sparrowwallet/sparrow/transaction/headers.fxml
index 216dfaa..7d046a5 100644
--- a/src/main/resources/com/sparrowwallet/sparrow/transaction/headers.fxml
+++ b/src/main/resources/com/sparrowwallet/sparrow/transaction/headers.fxml
@@ -78,8 +78,8 @@
         <Tab text="Overview" closable="false">
             <VBox spacing="8" alignment="CENTER">
                 <Region VBox.vgrow="SOMETIMES" />
-                <TransactionDiagram fx:id="transactionDiagram" maxWidth="700" final="true"/>
-                <TransactionDiagramLabel fx:id="transactionDiagramLabel" maxWidth="640" prefWidth="640" />
+                <TransactionDiagram fx:id="transactionDiagram" final="true"/>
+                <TransactionDiagramLabel fx:id="transactionDiagramLabel" />
                 <Region VBox.vgrow="SOMETIMES" />
             </VBox>
         </Tab>
diff --git a/src/main/resources/com/sparrowwallet/sparrow/wallet/send.fxml b/src/main/resources/com/sparrowwallet/sparrow/wallet/send.fxml
index 254cef7..4eeee9e 100644
--- a/src/main/resources/com/sparrowwallet/sparrow/wallet/send.fxml
+++ b/src/main/resources/com/sparrowwallet/sparrow/wallet/send.fxml
@@ -153,7 +153,7 @@
                 </AnchorPane>
             </GridPane>
             <StackPane VBox.vgrow="SOMETIMES">
-                <TransactionDiagram fx:id="transactionDiagram" maxWidth="700" />
+                <TransactionDiagram fx:id="transactionDiagram" />
             </StackPane>
         </VBox>
     </center>

Risk score

Why this scored 15/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 0/15

Confidence 10/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 15/100

Community notes

Related watches

avoid deleting the backups of same-prefixed wallets

verify proof of work on chain tips and warn when a tip goes stale

prevent a password change from re-encrypting wallets whose filenames share the same prefix