let screen readers reach dialog contents on macOS and give the settings dialog a title
What changed, and why it matters
This commit fixes two accessibility issues in the Sparrow Wallet desktop app on macOS. It changes how screen readers (assistive technology for visually impaired users) understand dialog windows, and it adds a visible title to the Settings dialog. There is no indication this change is related to security or that it fixes any vulnerability.
No security action required. Treat as a normal accessibility/usability improvement. If reviewing for supply-chain risk, verify the import of javafx.scene.AccessibleRole is standard JavaFX API and the change is limited to UI accessibility.
Security signals we found
No security signals present in the diff.
Change is purely accessibility/usability: screen-reader role mapping and dialog title.
No input handling, parsing, privilege, or cryptographic code is modified.
Evidence from the diff
The patch makes two small JavaFX UI changes. In AppServices.java, when running on macOS, any dialog root node whose AccessibleRole is DIALOG is reassigned to PARENT, because macOS VoiceOver does not recognize the DIALOG role and reports the dialog as an unknown element. In SettingsDialog.java, setTitle(“Settings”) is added so the dialog has a proper window title. The diff contains no security-relevant code paths (no cryptography, network, file, authentication, or privilege changes).
Changed components
src/main/java/com/sparrowwallet/sparrow/AppServices.javasrc/main/java/com/sparrowwallet/sparrow/settings/SettingsDialog.javaInspect captured patch +6 / −0
### src/main/java/com/sparrowwallet/sparrow/AppServices.java
@@ -41,6 +41,7 @@
import javafx.concurrent.Task;
import javafx.concurrent.Worker;
import javafx.fxml.FXMLLoader;
+import javafx.scene.AccessibleRole;
import javafx.scene.Node;
import javafx.scene.Parent;
import javafx.scene.Scene;
@@ -1001,6 +1002,10 @@ public static void setStageIcon(Window window) {
if(Config.get().isChunkAddresses()) {
stage.getScene().getRoot().getStyleClass().add("chunk-addresses");
}
+ //macOS has no accessibility role for DIALOG and exposes it as an unknown element around the whole dialog
+ if(OsType.getCurrent() == OsType.MACOS && stage.getScene().getRoot().getAccessibleRole() == AccessibleRole.DIALOG) {
+ stage.getScene().getRoot().setAccessibleRole(AccessibleRole.PARENT);
+ }
}
}
### src/main/java/com/sparrowwallet/sparrow/settings/SettingsDialog.java
@@ -25,6 +25,7 @@ public SettingsDialog(SettingsGroup initialGroup) {
public SettingsDialog(SettingsGroup initialGroup, boolean initialSetup) {
final DialogPane dialogPane = getDialogPane();
AppServices.setStageIcon(dialogPane.getScene().getWindow());
+ setTitle("Settings");
try {
FXMLLoader settingsLoader = new FXMLLoader(AppServices.class.getResource("settings/settings.fxml"));Why this scored 20/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.