revise wording for non-default sighash warnings
What the developer wrote
Authored by Craig Raw
revise wording for non-default sighash warnings
What changed, and why it matters
This commit only changes the wording of a warning message shown to users when a Bitcoin transaction file (PSBT) uses a non-standard signature hash type. The old message said the PSBT 'may be unsafe to sign,' and the new message tells the user to 'Review this PSBT carefully before signing.' The underlying security check and behavior are unchanged; only the label and explanatory text were softened.
No security action required; this is a cosmetic wording change. Reviewers may want to confirm the new wording still clearly warns users about the risk of non-default sighash types.
Security signals we found
No functional code change
UI wording revision only
No change to signature hash verification logic
Evidence from the diff
The patch modifies AppController.java where psbt.verifySigHashes() throws a PSBTSignatureException. It updates the dialog title from ‘Unsafe PSBT’ to ‘Non-Default Sighash’ and changes the body text from ‘This PSBT may be unsafe to sign.’ to ‘Review this PSBT carefully before signing.’ No logic, verification, or control-flow changes are present.
Changed components
src/main/java/com/sparrowwallet/sparrow/AppController.javaInspect captured patch +3 / −3
diff --git a/src/main/java/com/sparrowwallet/sparrow/AppController.java b/src/main/java/com/sparrowwallet/sparrow/AppController.java
index 12e138d..534e4bf 100644
--- a/src/main/java/com/sparrowwallet/sparrow/AppController.java
+++ b/src/main/java/com/sparrowwallet/sparrow/AppController.java
@@ -2062,8 +2062,8 @@ public class AppController implements Initializable {
try {
psbt.verifySigHashes();
} catch(PSBTSignatureException e) {
- Optional<ButtonType> result = AppServices.showWarningDialog("Unsafe PSBT",
- e.getMessage() + "\n\nThis PSBT may be unsafe to sign.\n\nOpen the transaction?", ButtonType.YES, ButtonType.NO);
+ Optional<ButtonType> result = AppServices.showWarningDialog("Non-Default Sighash",
+ e.getMessage() + "\n\nReview this PSBT carefully before signing.\n\nOpen the transaction?", ButtonType.YES, ButtonType.NO);
if(result.isEmpty() || result.get() != ButtonType.YES) {
return;
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.