AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 57 Bitcoin

verify silent payment outputs against the open wallet providing all inputs when a psbt is exported or combined before finalizing

Public commit record

What the developer wrote

Authored by Craig Raw

60/100 · Adequate
verify silent payment outputs against the open wallet providing all inputs when a psbt is exported or combined before finalizing
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a gap in how Sparrow Wallet checks Silent Payment addresses when a partially-built transaction (PSBT) is exported or combined before it is finalized. Previously, the wallet only verified the Silent Payment output against the wallet that would eventually sign. If the PSBT had no signing wallet yet, the output could go unverified. The change makes the app also look at all currently open wallets and verify against the one that can prove all inputs, reducing the chance of paying to a wrong or attacker-controlled Silent Payment address.

Recommended action

Users who create or combine PSBTs with Silent Payment outputs should upgrade to a release containing this commit. Developers should review whether any other pre-finalization PSBT flows (e.g., loading, broadcasting, saving) also rely on signingWallet being non-null for Silent Payment verification.

Security signals we found

01

Silent Payment output verification bypass before PSBT finalization

02

PSBT combine/export code path previously lacked fallback wallet selection

03

Defensive fix expanding verification coverage rather than adding new crypto primitives

Risk score

Why this scored 57/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 9/15
Affected reach 8/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.