What the developer wrote
Authored by Craig Raw
add ledger nano gen5 support
What changed, and why it matters
This commit adds support for a new Ledger hardware wallet model (Ledger Nano generation 5) and also includes a small UI update to recognize the Trezor Safe 7 model in a list of devices that support passphrase toggling. There is nothing in the code changes that suggests a security vulnerability or malicious behavior.
No security action required. Treat as routine feature support update.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff updates a submodule reference for ‘drongo’ and ‘lark’ (likely to pull in Ledger Nano Gen5 device definitions) and adds WalletModel.TREZOR_SAFE_7 to an existing allow-list in UsbStatusButton.java that determines which USB devices get a ‘Toggle Passphrase’ submenu. The change is additive and follows the existing pattern.
Changed components
src/main/java/com/sparrowwallet/sparrow/control/UsbStatusButton.javadrongo submodulelark submoduleInspect captured patch +3 / −3
diff --git a/src/main/java/com/sparrowwallet/sparrow/control/UsbStatusButton.java b/src/main/java/com/sparrowwallet/sparrow/control/UsbStatusButton.java
index 7376cbb..47b9beb 100644
--- a/src/main/java/com/sparrowwallet/sparrow/control/UsbStatusButton.java
+++ b/src/main/java/com/sparrowwallet/sparrow/control/UsbStatusButton.java
@@ -28,7 +28,7 @@ public class UsbStatusButton extends MenuButton {
for(Device device : devices) {
MenuItem deviceItem = new MenuItem(device.getModel().toDisplayString());
if(!device.isNeedsPinSent() && (device.getModel() == WalletModel.TREZOR_1 || device.getModel() == WalletModel.TREZOR_T || device.getModel() == WalletModel.TREZOR_SAFE_3 ||
- device.getModel() == WalletModel.TREZOR_SAFE_5 || device.getModel() == WalletModel.KEEPKEY || device.getModel() == WalletModel.BITBOX_02 ||
+ device.getModel() == WalletModel.TREZOR_SAFE_5 || device.getModel() == WalletModel.TREZOR_SAFE_7 || device.getModel() == WalletModel.KEEPKEY || device.getModel() == WalletModel.BITBOX_02 ||
device.getModel() == WalletModel.ONEKEY_CLASSIC_1S || device.getModel() == WalletModel.ONEKEY_PRO)) {
deviceItem = new Menu(device.getModel().toDisplayString());
MenuItem toggleItem = new MenuItem("Toggle Passphrase" + (!device.getModel().externalPassphraseEntry() ? "" : (device.isNeedsPassphraseSent() ? " Off" : " On")));
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.