AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 42 Bitcoin

save silent payments found by a scan when fetching their history fails, and load wallets whose silent payment indexes are not contiguous

Public commit record

What the developer wrote

Authored by Craig Raw

50/100 · Thin
save silent payments found by a scan when fetching their history fails, and load wallets whose silent payment indexes are not contiguous
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes two related bugs in Sparrow Wallet's handling of silent payments. Silent payments are a privacy-preserving way to receive Bitcoin where each payment uses a unique address derived by the sender. The wallet scans the blockchain to find payments made to it. The first bug meant that if the wallet found silent payments during a scan but then failed to fetch their transaction history, those newly found payments could be lost instead of saved. The second bug meant that wallets with silent payment indexes that were not sequential (which is normal for silent payments) could fail to load or refresh properly because the code tried to fill in missing indexes as if they were ordinary derived addresses. The fix ensures found silent payments are saved even when history fetching fails, and that the wallet does not try to force silent payment indexes to be contiguous.

Recommended action

Users relying on silent payments should upgrade to a release containing this commit. Until upgraded, be aware that silent payment transactions discovered during scans that encounter server or network errors may not be persisted, and wallets with non-contiguous silent payment indexes may fail to refresh correctly. No immediate key-rotation or incident response is indicated because no key material is compromised.

Security signals we found

01

Data loss / state inconsistency: silent payment outputs discovered by scan could be discarded if subsequent history fetch failed or was skipped

02

Denial of wallet load / refresh: non-contiguous silent payment indexes triggered incorrect gap-limit filling behavior

03

Fix ensures wallet state changes made before a failure are persisted without advancing stored block height

04

No cryptographic, authentication, or network protocol changes; this is a wallet state management bug

Risk score

Why this scored 42/100

Our methodology →
Potential impact 12/30
Exploitability 5/25
Stealth signal 6/15
Affected reach 7/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.