save a bitcoin core server chosen or scanned that differs only in protocol
What changed, and why it matters
This is a small bug-fix commit in Sparrow Wallet's settings screen. When a user selected or scanned a Bitcoin Core server that was identical to the currently displayed one except for the protocol (for example, http vs https), the on-screen text fields did not change. Because Sparrow saves server settings only when those text fields change, the new protocol choice was silently lost. The fix explicitly saves the server configuration in that specific case. It is a data-loss/UX bug rather than a direct security vulnerability, though using the wrong protocol could indirectly affect connection security.
Treat as a minor bug fix with indirect security implications. Review that setCoreServerInConfig correctly validates and persists the protocol, and verify that protocol-only changes are now reflected in saved configuration and on restart. No urgent security response is indicated by the diff alone.
Security signals we found
Protocol downgrade/persistence gap: a protocol-only change could be dropped, leaving the wallet configured for unencrypted HTTP instead of HTTPS
UI state vs persisted state inconsistency
No input validation, authentication, or access-control changes in diff
Evidence from the diff
ServerSettingsController.java initializes the Bitcoin Core server view from Config. When a user picks or scans a server, the code updates coreHost and corePort text fields; listeners on those fields persist changes to Config. If the chosen/scanned server differs only by protocol (e.g., existing ‘http://host:port’ vs new ‘https://host:port’), neither host nor port changes, so the listeners never fire and the protocol change is not persisted. The patch adds an explicit call to setCoreServerInConfig(config) in that branch so the protocol-only change is saved. No cryptographic, authentication, or network-layer changes are present.
Changed components
src/main/java/com/sparrowwallet/sparrow/settings/ServerSettingsController.javaBitcoin Core server configuration UIConfig persistence for Bitcoin Core connection protocolInspect captured patch +2 / −0
### src/main/java/com/sparrowwallet/sparrow/settings/ServerSettingsController.java
@@ -332,6 +332,8 @@ public void initializeView(Config config) {
coreHost.setText(hostAndPort.getHost());
}
coreHost.positionCaret(coreHost.getText().length());
+ //A server differing from the one shown only in its protocol changes neither field, so the field listeners do not save it
+ setCoreServerInConfig(config);
}
}
});Why this scored 23/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.