AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 47 Bitcoin

upgrade tern to v1.1.2 and use it for bitcoin core rpc and paynym avatar requests

Public commit record

What the developer wrote

Authored by Craig Raw

50/100 · Thin
upgrade tern to v1.1.2 and use it for bitcoin core rpc and paynym avatar requests
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit upgrades an internal networking library called 'tern' and switches Bitcoin Core RPC, PayNym avatar, and Payjoin requests to use it. The change is mostly a refactoring to consolidate HTTP handling, fix proxy-switching races, and add timeouts so unreachable nodes cannot freeze the wallet. It also adds many tests that verify traffic goes through Tor for onion addresses, does not follow HTTP redirects, and pins self-signed HTTPS certificates. There is no direct evidence in the commit that this fixes a known exploit, but it removes risky behaviors such as infinite connection hangs and redirect following that could be abused.

Recommended action

Review the tern 1.1.2 source/diff for any behavioral changes in HttpEndpointClient (redirect policy, cookie handling, certificate validation, proxy resolution). Confirm that the new idle timeout does not break long-polling or rescan RPC calls; the code already disables read timeout for rescanning methods. Run the new tests and consider backporting if prior releases used the old HttpURLConnection path with infinite timeouts and redirect following.

Security signals we found

01

Replaced infinite HttpURLConnection timeouts with explicit 15s/60s connect and 10s idle timeouts

02

Added synchronized proxy update path to prevent use of stale Tor proxy

03

Added Closeable lifecycle to BitcoindTransport so connections are closed on stop/initialization failure

04

HTTP redirect following is now rejected for Bitcoin Core RPC and Payjoin (tested)

05

Onion Bitcoin Core RPC is forced through SOCKS5 proxy; clearnet/local nodes are direct

06

Self-signed HTTPS certificates pinned on first use for Bitcoin Core RPC

07

Removed Jetty client module requirement and logging configuration

08

Added tests verifying proxy routing, redirect rejection, certificate pinning, and connection reuse

Risk score

Why this scored 47/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 7/15
Affected reach 10/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.