AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 49 Bitcoin

mark a transaction tab height unverified when its proof cannot be obtained from a connected server, and fetch it again after the server changes

Public commit record

What the developer wrote

Authored by Craig Raw

50/100 · Thin
mark a transaction tab height unverified when its proof cannot be obtained from a connected server, and fetch it again after the server changes
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes how Sparrow Wallet handles transaction block-height information that a connected Electrum server reports but cannot prove with a cryptographic Merkle proof. Previously, if the server returned an empty or invalid proof, the wallet might still treat the reported height as verified. After the change, an unproven height is marked as 'server reported only' and the wallet re-fetches the proof when the server connection changes, rather than silently trusting the old value. This reduces the chance that a user is misled about whether a transaction is confirmed.

Recommended action

Reviewers should confirm that all paths which set a transaction's block height from server data now pass through isServerReported() checks, and that no other controllers bypass the re-verification on server change. Consider adding an integration test where a server first reports a fake height and then a second server reports a different height, to ensure the UI updates correctly.

Security signals we found

01

Merkle proof verification now rejects null/empty proofs explicitly

02

Server-reported transaction heights are re-verified after server changes

03

UI no longer displays an unsubstantiated block height as verified

04

New unit tests for empty proof handling and server-reported status logic

Risk score

Why this scored 49/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 10/15
Affected reach 8/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.