AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 35 Bitcoin

use the default port for a proxy given without one in http requests, bwt, tor identity changes and tor status checks

Public commit record

What the developer wrote

Authored by Craig Raw

50/100 · Thin
use the default port for a proxy given without one in http requests, bwt, tor identity changes and tor status checks
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a bug where Sparrow Wallet would use an invalid port number when a user configured a Tor/proxy server address without explicitly specifying a port. Previously, the code called getPort(), which could return -1 or an undefined value when no port was provided, causing connection failures or possibly connecting to the wrong service. The fix supplies the default SOCKS/Tor proxy port (9050) in those situations across Tor status checks, BWT (Bitcoin Wallet Tracker) startup, HTTP proxy setup, Tor identity rotation, and the terminal UI.

Recommended action

Treat as a reliability/robustness fix rather than a critical security vulnerability. Users relying on custom proxy servers should ensure they upgrade and verify proxy settings include an explicit port if non-default. Review whether any other HostAndPort.getPort() calls in the codebase lack a default-port fallback.

Security signals we found

01

Use of default port fallback for network proxy configuration

02

Potential prior behavior of connecting to invalid/undefined port when proxy string lacked port

03

Tor control port derived from proxy port (proxy port + 1), making correct proxy port handling security-relevant for identity rotation

04

Fix touches both GUI and terminal proxy status checks, BWT bitcoind proxy configuration, and HTTP proxy supplier

Risk score

Why this scored 35/100

Our methodology →
Potential impact 8/30
Exploitability 6/25
Stealth signal 4/15
Affected reach 7/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.