hide the no-wallets hint while tabs are open so screen readers skip it, and fix its drag-over outline
What changed, and why it matters
This commit is a user-interface polish change for accessibility and visual styling. It hides the on-screen 'no wallets open' hint when wallet tabs are open so screen-reader software does not read it aloud, and it corrects a CSS selector so the dotted outline shown while dragging files over the window appears correctly. There is no security-relevant behavior in the diff.
No security action needed. Treat as a normal UI/accessibility fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change wraps the no-wallet placeholder content in a new StackPane (noTabsPane) and binds its visibleProperty to whether the TabPane has zero tabs. It also changes the CSS selector from .drag-over > .background-box (direct child) to .drag-over .background-box (descendant) and removes a now-redundant .drag-over > .background-text rule. These are purely presentational adjustments.
Changed components
AppController.javaapp.cssapp.fxmlInspect captured patch +16 / −14
### src/main/java/com/sparrowwallet/sparrow/AppController.java
@@ -214,6 +214,9 @@ public class AppController implements Initializable {
@FXML
private StackPane rootStack;
+ @FXML
+ private StackPane noTabsPane;
+
@FXML
private TabPane tabs;
@@ -348,6 +351,7 @@ void initializeView() {
//Draggle tabs introduce unwanted movement when selecting between them
//tabs.setTabDragPolicy(TabPane.TabDragPolicy.REORDER);
tabs.getTabs().addListener(tabsChangeListener);
+ noTabsPane.visibleProperty().bind(Bindings.isEmpty(tabs.getTabs()));
tabs.getScene().getWindow().setOnCloseRequest(event -> {
EventManager.get().unregister(this);
### src/main/resources/com/sparrowwallet/sparrow/app.css
@@ -7,7 +7,7 @@
-fx-fill: transparent;
}
-.drag-over > .background-box {
+.drag-over .background-box {
-fx-stroke: #383a42;
}
@@ -31,10 +31,6 @@
-fx-underline: true;
}
-.drag-over > .background-text {
- -fx-fill: #383a42;
-}
-
.tab-label .failure {
-fx-text-fill: rgb(202, 18, 67);
}
### src/main/resources/com/sparrowwallet/sparrow/app.fxml
@@ -171,15 +171,17 @@
</menus>
</MenuBar>
<DecorationPane fx:id="rootStack" VBox.vgrow="ALWAYS">
- <Rectangle styleClass="background-box" width="450" height="230" />
- <HBox alignment="CENTER">
- <VBox alignment="CENTER" spacing="15">
- <HBox><Text styleClass="background-text" text="File menu → "/><Hyperlink onAction="#newWallet" styleClass="background-text,background-link" text="New Wallet"/><Text styleClass="background-text" text=" or"/></HBox>
- <HBox><Text styleClass="background-text" text="File menu → "/><Hyperlink onAction="#openWallet" styleClass="background-text,background-link" text="Open Wallet"/><Text styleClass="background-text" text=" or"/></HBox>
- <HBox><Text styleClass="background-text" text="File menu → "/><Hyperlink onAction="#importWallet" styleClass="background-text,background-link" text="Import Wallet"/><Text styleClass="background-text" text=" or"/></HBox>
- <Text styleClass="background-text" text="drag files to open" />
- </VBox>
- </HBox>
+ <StackPane fx:id="noTabsPane">
+ <Rectangle styleClass="background-box" width="450" height="230" />
+ <HBox alignment="CENTER">
+ <VBox alignment="CENTER" spacing="15">
+ <HBox><Text styleClass="background-text" text="File menu → "/><Hyperlink onAction="#newWallet" styleClass="background-text,background-link" text="New Wallet"/><Text styleClass="background-text" text=" or"/></HBox>
+ <HBox><Text styleClass="background-text" text="File menu → "/><Hyperlink onAction="#openWallet" styleClass="background-text,background-link" text="Open Wallet"/><Text styleClass="background-text" text=" or"/></HBox>
+ <HBox><Text styleClass="background-text" text="File menu → "/><Hyperlink onAction="#importWallet" styleClass="background-text,background-link" text="Import Wallet"/><Text styleClass="background-text" text=" or"/></HBox>
+ <Text styleClass="background-text" text="drag files to open" />
+ </VBox>
+ </HBox>
+ </StackPane>
<TabPane fx:id="tabs" />
</DecorationPane>
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.