What changed, and why it matters
This commit updates the PGP verification library used by Sparrow Wallet and tweaks the logic that decides when a downloaded release file is considered valid. The code change makes the app less likely to wrongly disable manifest verification when the release file happens to match the detached signature file. On its own, the change looks like a defensive hardening fix, but the commit message does not explain whether it fixes a known security bug.
Review the pgpainless 1.7.8 release notes and changelog for security fixes. Audit DownloadVerifierDialog.java to confirm the new condition fully addresses the verification edge case and does not introduce new bypass paths. Consider adding tests covering cases where manifest, release, and signature files have overlapping content.
Security signals we found
Dependency upgrade of a cryptographic library (pgpainless)
Logic change in signature/verification flow
Potential bypass of manifest verification when release content equals signature content
No explicit security rationale or CVE cited in commit message
Evidence from the diff
The diff upgrades org.pgpainless:pgpainless-core from 1.7.7 to 1.7.8 and updates the Gradle verification metadata and drongo submodule accordingly. In DownloadVerifierDialog.java, the condition that disables manifest verification now also requires manifest.get().equals(signature.get()) to be false. Previously, if the manifest and release files had identical content, the app would skip manifest verification even when a detached signature file existed. The new check prevents that edge case. The pgpainless 1.7.8 release may contain its own fixes, but the commit provides no changelog or CVE references.
Changed components
org.pgpainless:pgpainless-core dependencyDownloadVerifierDialog.java verification logicdrongo submoduleGradle verification metadataInspect captured patch +11 / −8
### drongo
@@ -1 +1 @@
-Subproject commit 7b2ab9cd043a56bb59dc2bad08ee066ac3783a9b
+Subproject commit 5c065732eb19838d4e63c2e3dfe2d3e093bd05df
### gradle/verification-metadata.xml
@@ -42,7 +42,7 @@
<trusted-key id="635EE627345F3C1DD422B2E207D3516820BCF6B1" group="com.github.ben-manes.caffeine" name="caffeine" version="3.2.3"/>
<trusted-key id="655980F800BEDF4F315D5427DB9F4F2943F9BBC7" group="org.controlsfx" name="controlsfx" version="11.2.3"/>
<trusted-key id="66D7CBFF956830FE9F5A723AFE6C7D77A1CE15A6" group="org.gradlex" name="extra-java-module-info" version="1.13.1"/>
- <trusted-key id="698B135CC8820C57837DE099597CBBDBE4F6F054" group="org.pgpainless" name="pgpainless-core" version="1.7.7"/>
+ <trusted-key id="698B135CC8820C57837DE099597CBBDBE4F6F054" group="org.pgpainless" name="pgpainless-core" version="1.7.8"/>
<trusted-key id="6F538074CCEBF35F28AF9B066A0975F8B1127B83" group="org.jetbrains.kotlin"/>
<trusted-key id="7616EB882DAF57A11477AAF559A252FB1199D873" group="com.google.code.findbugs" name="jsr305" version="3.0.2"/>
<trusted-key id="782AF7972653864E80AD3CFD20DBD25146A6FAF1" group="^org[.]kotlincrypto($|([.].*))" regex="true"/>
@@ -881,6 +881,9 @@
</artifact>
</component>
<component group="io.opentelemetry" name="opentelemetry-bom" version="1.67.0">
+ <artifact name="opentelemetry-bom-1.67.0.module">
+ <sha512 value="27bd72ce5aed5582c07217768624e9bbc734062531fbfbf153ef3d9c96dc5bfea9f30577bd875a9695e90b7f8aa42d0ca9d3b52b68782e92a4d0ec671d234afb" origin="Generated by Gradle"/>
+ </artifact>
<artifact name="opentelemetry-bom-1.67.0.pom">
<sha512 value="88ed8cc5255161c5b446f350507c114439dc753be16131c3fc1a7f19909ec0eb1c6c1cdd27e7879c32ec75e9fc0c0c0a47eb46ac154c5adca3593c72fd159fe2" origin="Generated by Gradle"/>
</artifact>
@@ -1683,12 +1686,12 @@
<sha512 value="a34a1cc4ac50724e0798f4d8ee677207ba68e4f311d9d5cc200dd9351ea63f556589aa42c7a0df90b53634ae41bae3646d5115eb029aab11077a20f7b144bf3f" origin="Generated by Gradle"/>
</artifact>
</component>
- <component group="org.pgpainless" name="pgpainless-core" version="1.7.7">
- <artifact name="pgpainless-core-1.7.7.jar">
- <sha512 value="4127bfdfd8292ca340c919ec35c5efe4997fa11f9942bbd90da71ef5ad08303f9b98c09c80e9c7d33706be4379c6adf44f9f9b79e49fc51ede5a12ebb67b8f72" origin="Generated by Gradle"/>
+ <component group="org.pgpainless" name="pgpainless-core" version="1.7.8">
+ <artifact name="pgpainless-core-1.7.8.jar">
+ <sha512 value="3df2c2ec8d47f17eecdab906625cab630a4293ca8b88373418f049e906eca751af02a1e787bacafeccf36ea925642d22f70a4b48fe694d76cad81962a842e438" origin="Generated by Gradle"/>
</artifact>
- <artifact name="pgpainless-core-1.7.7.module">
- <sha512 value="70a7d7203e89548eafd2e3a9dc25002d0cf5d220aa0beb14f5d5f37a04acce451819d1b897f95d024e7b564d5b5c44b7f4f8fe5ff4c5ffa727488280e4fb5739" origin="Generated by Gradle"/>
+ <artifact name="pgpainless-core-1.7.8.module">
+ <sha512 value="eecb612cc6ba50b59c20a60a61d9f91bade4d4085cc231753c0e4cc245ab74525904ef76d59f478bddec04061c2900ddde51b86a11c11ef1b58bc823262589a3" origin="Generated by Gradle"/>
</artifact>
</component>
<component group="org.reactfx" name="reactfx" version="2.0-M5">
### src/main/java/com/sparrowwallet/sparrow/control/DownloadVerifierDialog.java
@@ -332,7 +332,7 @@ private void verify() {
publicKeyDisabled.set(true);
}
- if(manifest.get().equals(release.get()) && !isSparrowManifest(manifest.get())) {
+ if(manifest.get().equals(release.get()) && !manifest.get().equals(signature.get()) && !isSparrowManifest(manifest.get())) {
manifestDisabled.set(true);
releaseHash.setText("No hash required, signature signs release file directly");
releaseHash.setGraphic(GlyphUtils.getSuccessGlyph());Why this scored 48/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.