replace chart data points with a one-line summary for screen readers on the balance, utxo and fee rate charts
What changed, and why it matters
This commit improves accessibility for users who rely on screen readers. It replaces the detailed list of chart data points (which screen readers would try to read out one by one) with a single plain-language summary sentence for four different charts: balance history, fee rates, mempool size, and UTXO values. There is no security-relevant change here.
No security action needed. Treat as a normal accessibility/usability improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies four JavaFX chart controls to set AccessibleRole.TEXT, override queryAccessibleAttribute(CHILDREN) to return an empty list, and populate setAccessibleText() with a concise summary. This prevents assistive technologies from traversing every chart node/data point while still conveying the chart’s meaning. No input handling, cryptography, networking, authentication, or data validation logic is changed.
Changed components
src/main/java/com/sparrowwallet/sparrow/control/BalanceChart.javasrc/main/java/com/sparrowwallet/sparrow/control/BlockTargetFeeRatesChart.javasrc/main/java/com/sparrowwallet/sparrow/control/MempoolSizeFeeRatesChart.javasrc/main/java/com/sparrowwallet/sparrow/control/UtxosChart.javaInspect captured patch +100 / −0
### src/main/java/com/sparrowwallet/sparrow/control/BalanceChart.java
@@ -9,25 +9,42 @@
import com.sparrowwallet.sparrow.wallet.TransactionEntry;
import com.sparrowwallet.sparrow.wallet.WalletTransactionsEntry;
import javafx.beans.NamedArg;
+import javafx.collections.FXCollections;
+import javafx.scene.AccessibleAttribute;
+import javafx.scene.AccessibleRole;
import javafx.scene.Node;
import javafx.scene.chart.*;
+import java.text.DateFormat;
+import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Date;
import java.util.List;
+import java.util.Objects;
import java.util.Set;
import java.util.stream.Collectors;
import java.util.stream.Stream;
public class BalanceChart extends LineChart<Number, Number> {
private static final int MAX_VALUES = 500;
+ private static final DateFormat SUMMARY_DATE_FORMAT = new SimpleDateFormat("MMM yyyy");
private XYChart.Series<Number, Number> balanceSeries;
private TransactionEntry selectedEntry;
public BalanceChart(@NamedArg("xAxis") Axis<Number> xAxis, @NamedArg("yAxis") Axis<Number> yAxis) {
super(xAxis, yAxis);
+ setAccessibleRole(AccessibleRole.TEXT);
+ }
+
+ @Override
+ public Object queryAccessibleAttribute(AccessibleAttribute attribute, Object... parameters) {
+ if(attribute == AccessibleAttribute.CHILDREN) {
+ return FXCollections.emptyObservableList();
+ }
+
+ return super.queryAccessibleAttribute(attribute, parameters);
}
public void initialize(WalletTransactionsEntry walletTransactionsEntry) {
@@ -73,6 +90,7 @@ public void update(WalletTransactionsEntry walletTransactionsEntry) {
}
balanceSeries.getData().addAll(balanceDataList);
+ setAccessibleText(getSummary(walletTransactionsEntry));
if(selectedEntry != null) {
select(selectedEntry);
@@ -97,6 +115,18 @@ private Stream<Entry> getTransactionEntries(WalletTransactionsEntry walletTransa
return reducedEntries.stream();
}
+ private String getSummary(WalletTransactionsEntry walletTransactionsEntry) {
+ List<Date> dates = walletTransactionsEntry.getChildren().stream().map(entry -> (TransactionEntry)entry)
+ .filter(txEntry -> txEntry.getBlockTransaction().getHeight() > 0).map(txEntry -> txEntry.getBlockTransaction().getDate())
+ .filter(Objects::nonNull).sorted().toList();
+ if(dates.isEmpty()) {
+ return "Balance history chart, no confirmed transactions";
+ }
+
+ return "Balance history chart of " + dates.size() + " confirmed transaction" + (dates.size() == 1 ? "" : "s") + " from "
+ + SUMMARY_DATE_FORMAT.format(dates.getFirst()) + " to " + SUMMARY_DATE_FORMAT.format(dates.getLast());
+ }
+
public void select(TransactionEntry transactionEntry) {
Set<Node> selectedSymbols = lookupAll(".chart-line-symbol.selected");
for(Node selectedSymbol : selectedSymbols) {
### src/main/java/com/sparrowwallet/sparrow/control/BlockTargetFeeRatesChart.java
@@ -1,13 +1,19 @@
package com.sparrowwallet.sparrow.control;
import com.sparrowwallet.sparrow.AppServices;
+import com.sparrowwallet.sparrow.UnitFormat;
+import com.sparrowwallet.sparrow.io.Config;
import javafx.beans.NamedArg;
+import javafx.collections.FXCollections;
+import javafx.scene.AccessibleAttribute;
+import javafx.scene.AccessibleRole;
import javafx.scene.Node;
import javafx.scene.chart.Axis;
import javafx.scene.chart.LineChart;
import javafx.scene.chart.XYChart;
import java.util.Iterator;
+import java.util.List;
import java.util.Map;
public class BlockTargetFeeRatesChart extends LineChart<String, Number> {
@@ -16,6 +22,16 @@ public class BlockTargetFeeRatesChart extends LineChart<String, Number> {
public BlockTargetFeeRatesChart(@NamedArg("xAxis") Axis<String> xAxis, @NamedArg("yAxis") Axis<Number> yAxis) {
super(xAxis, yAxis);
+ setAccessibleRole(AccessibleRole.TEXT);
+ }
+
+ @Override
+ public Object queryAccessibleAttribute(AccessibleAttribute attribute, Object... parameters) {
+ if(attribute == AccessibleAttribute.CHILDREN) {
+ return FXCollections.emptyObservableList();
+ }
+
+ return super.queryAccessibleAttribute(attribute, parameters);
}
public void initialize() {
@@ -35,11 +51,26 @@ public void update(Map<Integer, Double> targetBlocksFeeRates) {
}
}
+ setAccessibleText(getSummary());
+
if(selectedTargetBlocks != null) {
select(selectedTargetBlocks);
}
}
+ private String getSummary() {
+ List<XYChart.Data<String, Number>> data = feeRateSeries.getData();
+ if(data.isEmpty()) {
+ return "Fee rates by target blocks, no fee rates";
+ }
+
+ UnitFormat format = Config.get().getUnitFormat() == null ? UnitFormat.DOT : Config.get().getUnitFormat();
+ XYChart.Data<String, Number> first = data.getFirst();
+ XYChart.Data<String, Number> last = data.getLast();
+ return "Fee rates by target blocks, from " + format.getCurrencyFormat().format(first.getYValue()) + " sats/vB for " + first.getXValue() + " block"
+ + (first.getXValue().equals("1") ? "" : "s") + " to " + format.getCurrencyFormat().format(last.getYValue()) + " sats/vB for " + last.getXValue() + " blocks";
+ }
+
public void select(Integer targetBlocks) {
Node selectedSymbol = lookup(".chart-line-symbol.selected");
if(selectedSymbol != null) {
### src/main/java/com/sparrowwallet/sparrow/control/MempoolSizeFeeRatesChart.java
@@ -11,6 +11,8 @@
import javafx.geometry.Insets;
import javafx.geometry.Point2D;
import javafx.geometry.Pos;
+import javafx.scene.AccessibleAttribute;
+import javafx.scene.AccessibleRole;
import javafx.scene.Cursor;
import javafx.scene.Node;
import javafx.scene.Scene;
@@ -129,7 +131,17 @@ public MempoolSizeFeeRatesChart(@NamedArg("xAxis") Axis<String> xAxis, @NamedArg
setOnMouseClicked(expandedChartHandler);
}
+ @Override
+ public Object queryAccessibleAttribute(AccessibleAttribute attribute, Object... parameters) {
+ if(attribute == AccessibleAttribute.CHILDREN) {
+ return FXCollections.emptyObservableList();
+ }
+
+ return super.queryAccessibleAttribute(attribute, parameters);
+ }
+
public void initialize() {
+ setAccessibleRole(AccessibleRole.TEXT);
getStyleClass().add("vsizeChart");
setCreateSymbols(false);
setCursor(Cursor.CROSSHAIR);
@@ -152,6 +164,7 @@ public void update(Map<Date, Set<MempoolRateSize>> mempoolRateSizes) {
Map<Date, Set<MempoolRateSize>> periodRateSizes = getPeriodRateSizes(mempoolRateSizes);
Map<Date, String> categories = getCategories(periodRateSizes);
+ setAccessibleText(getSummary(periodRateSizes));
CategoryAxis categoryAxis = (CategoryAxis)getXAxis();
categoryAxis.setTickMarkVisible(false);
@@ -243,6 +256,18 @@ public Number fromString(String string) {
}
}
+ private String getSummary(Map<Date, Set<MempoolRateSize>> periodRateSizes) {
+ String summary = "Mempool size by fee rate over the last " + maxPeriodHours + " hours";
+ Optional<Set<MempoolRateSize>> latest = periodRateSizes.values().stream().reduce((first, second) -> second);
+ if(latest.isPresent()) {
+ long vSize = latest.get().stream().mapToLong(MempoolRateSize::getVSize).sum();
+ summary += vSize >= 1_000_000 ? String.format(Locale.ENGLISH, ", currently %.1f MvB", vSize / 1_000_000d)
+ : String.format(Locale.ENGLISH, ", currently %,d kvB", vSize / 1000);
+ }
+
+ return summary;
+ }
+
private Map<Date, Set<MempoolRateSize>> getPeriodRateSizes(Map<Date, Set<MempoolRateSize>> mempoolRateSizes) {
if(mempoolRateSizes.size() == 1) {
return mempoolRateSizes;
### src/main/java/com/sparrowwallet/sparrow/control/UtxosChart.java
@@ -8,6 +8,9 @@
import com.sparrowwallet.sparrow.wallet.UtxoEntry;
import com.sparrowwallet.sparrow.wallet.WalletUtxosEntry;
import javafx.beans.NamedArg;
+import javafx.collections.FXCollections;
+import javafx.scene.AccessibleAttribute;
+import javafx.scene.AccessibleRole;
import javafx.scene.Node;
import javafx.scene.chart.*;
import javafx.scene.control.Tooltip;
@@ -30,6 +33,16 @@ public class UtxosChart extends BarChart<String, Number> {
public UtxosChart(@NamedArg("xAxis") Axis<String> xAxis, @NamedArg("yAxis") Axis<Number> yAxis) {
super(xAxis, yAxis);
+ setAccessibleRole(AccessibleRole.TEXT);
+ }
+
+ @Override
+ public Object queryAccessibleAttribute(AccessibleAttribute attribute, Object... parameters) {
+ if(attribute == AccessibleAttribute.CHILDREN) {
+ return FXCollections.emptyObservableList();
+ }
+
+ return super.queryAccessibleAttribute(attribute, parameters);
}
public void initialize(WalletUtxosEntry walletUtxosEntry) {
@@ -47,6 +60,7 @@ public void update(WalletUtxosEntry walletUtxosEntry) {
.collect(Collectors.toList());
totalUtxos = utxoDataList.size();
+ setAccessibleText("UTXO values chart of " + totalUtxos + " UTXO" + (totalUtxos == 1 ? "" : "s"));
if(utxoDataList.size() > MAX_BARS) {
List<Data<String, Number>> otherDataList = utxoDataList.subList(MAX_BARS - 1, utxoDataList.size());
List<Entry> otherEntries = otherDataList.stream().map(data -> (Entry)data.getExtraValue()).collect(Collectors.toList());Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.